Skip to content

Correct the type for Deploy.init #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rswarbrick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct the type for Deploy.init #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/dvsim/job/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
)

if TYPE_CHECKING:
from dvsim.flow.sim import SimCfg
from dvsim.flow.base import FlowCfg
from dvsim.modes import BuildMode
from dvsim.sim.flow import SimCfg


__all__ = (
Expand Down Expand Up @@ -59,7 +60,7 @@ def __str__(self) -> str:
"""Get a string representation of the deployment object."""
return pprint.pformat(self.__dict__) if log.isEnabledFor(log.VERBOSE) else self.full_name

def __init__(self, sim_cfg: "SimCfg") -> None:
def __init__(self, sim_cfg: "FlowCfg") -> None:
Copy link
Copy Markdown
Contributor

@AlexJones0 AlexJones0 Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a useful fix. I wonder, would it not be a good idea to rename sim_cfg -> flow_cfg as well?

"""Initialise deployment object.

Args:
Expand Down
2 changes: 1 addition & 1 deletion src/dvsim/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _build_logger() -> DVSimLogger:
# Log any unhandled exceptions
_previous_excepthook = sys.excepthook

def _handle_exception(exc_type, exc_value, exc_tb):
def _handle_exception(exc_type, exc_value, exc_tb) -> None:
logger.critical("Unhandled exception", exc_info=(exc_type, exc_value, exc_tb))
_previous_excepthook(exc_type, exc_value, exc_tb)

Expand Down
Loading