Enhance resize function to track detent index changes

[allthetime]

fix(android): prevent TrueSheet collapse to detent 0 on dynamic content layout changes

Summary

Type of Change

• [✅ ] Bug fix
• New feature
• Breaking change
• Documentation update

Test Plan

repro

Checklist

• [✅ ] I tested on iOS
• [ ✅] I tested on Android
• I tested on Web code only touches one android native file)
• I updated the documentation (if needed)
• I added a changelog entry (if needed)

[vercel]

@allthetime is attempting to deploy a commit to the RealEdge Inc Team on Vercel.

A member of the Team first needs to authorize it.

[karimcambridge]

I'm wondering if this is the issue I’m having! I have a ride flow and sometimes when lets say a user switches to whatsapp or the map and come back the true sheet is gone, and they get upset. I hope this is the fix!

[allthetime]

@karimcambridge you can give this patch a try and see!

I'm running @lodev09/react-native-true-sheet@3.10.1

diff --git a/node_modules/@lodev09/react-native-true-sheet/android/src/main/java/com/lodev09/truesheet/TrueSheetViewController.kt b/node_modules/@lodev09/react-native-true-sheet/android/src/main/java/com/lodev09/truesheet/TrueSheetViewController.kt
index e0c5d2e..cd3ac26 100644
--- a/node_modules/@lodev09/react-native-true-sheet/android/src/main/java/com/lodev09/truesheet/TrueSheetViewController.kt
+++ b/node_modules/@lodev09/react-native-true-sheet/android/src/main/java/com/lodev09/truesheet/TrueSheetViewController.kt
@@ -705,18 +705,25 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :
 
   fun resize(detentIndex: Int) {
     if (!isPresented) return
-
     // Commit the new index so keyboardWillHide restores to it instead of the stale one
     if (detentIndexBeforeKeyboard >= 0) {
       detentIndexBeforeKeyboard = detentIndex
     }
-
     setupDimmedBackground()
+    
+    val oldIndex = currentDetentIndex
+    currentDetentIndex = detentIndex
+    
     setStateForDetentIndex(detentIndex)
+    
+    if (oldIndex != detentIndex) {
+      val (index, position, detent) = getDetentInfoWithValue(detentIndex)
+      delegate?.viewControllerDidChangeDetent(index, position, detent)
+      sheetView?.updateGrabberAccessibilityValue(index, detents.size)
+    }
     resizePromise?.invoke()
     resizePromise = null
   }
-
   private fun setupSheetInCoordinator(coordinator: TrueSheetCoordinatorLayout, sheet: TrueSheetBottomSheetView) {
     // Add this controller as content to the sheet
     (parent as? ViewGroup)?.removeView(this)

[lodev09]

@allthetime do you have a video showing this bug? I'll try to replicate and see how this PR fixes the issue.

[allthetime]

@allthetime do you have a video showing this bug? I'll try to replicate and see how this PR fixes the issue.

First of all, thanks for this DOPE library.

Second I have a minimal repro here (direct link to App.tsx): https://github.com/allthetime/true_sheet_android_resize_collapse_bug/blob/master/App.tsx.

Thirdly, here's a video - its very quick/hard to notice. I'm pressing the "Resize to detent 1" button. It quickly tries to go up but then goes back down. Pressing it again does nothing and the sheet stays at detent 0 height.

truesheetproblem.webm

With my patch in place this doesn't happen anymore and it behaves as expected.