fix(ios): clean up gesture recognizer targets on sheet dismiss#609
Open
davidecallegaro wants to merge 1 commit intolodev09:mainfrom
Open
fix(ios): clean up gesture recognizer targets on sheet dismiss#609davidecallegaro wants to merge 1 commit intolodev09:mainfrom
davidecallegaro wants to merge 1 commit intolodev09:mainfrom
Conversation
setupGestureRecognizer adds handlePanGesture: as a target to both the presented view's and the inner ScrollView's pan gesture recognizers via addTarget:action:. However, there is no corresponding removeTarget:action: call when the sheet disappears. This leaves orphaned gesture handler targets that can block scroll events on the presenting view controller when navigating away and returning. This commit: - Adds GestureUtil.detachPanGestureHandler to mirror attachPanGestureHandler - Adds cleanupGestureRecognizer to TrueSheetViewController - Calls cleanup in viewWillDisappear to remove targets before the view disappears - Re-attaches in viewDidAppear when the sheet reappears (e.g. after a child sheet is dismissed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@davidecallegaro is attempting to deploy a commit to the Jovanni's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lodev09
approved these changes
Mar 19, 2026
Owner
lodev09
left a comment
lodev09
left a comment
There was a problem hiding this comment.
LGTM. Just update changelog and is good to merge.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupGestureRecognizeraddshandlePanGesture:as a target to the presented view's and inner ScrollView's pan gesture recognizers viaaddTarget:action:, but there is no correspondingremoveTarget:action:when the sheet disappearsChanges
detachPanGestureHandler:target:selector:to mirrorattachPanGestureHandlercleanupGestureRecognizermethodviewWillDisappear:to remove targets before the view disappearsviewDidAppear:when the sheet reappears (e.g. after a child sheet is dismissed)Reproduction
scrollable={true}on a screenTest plan