-
Notifications
You must be signed in to change notification settings - Fork 40
Decouple sync and release actions #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: localstack
Are you sure you want to change the base?
Conversation
9296029 to
09bb5a6
Compare
09bb5a6 to
784afee
Compare
784afee to
cd247e5
Compare
cd247e5 to
da5ff9f
Compare
da5ff9f to
398e6c9
Compare
398e6c9 to
2abe8b3
Compare
2abe8b3 to
51c9653
Compare
d12ab58 to
09b865f
Compare
09b865f to
2976974
Compare
2976974 to
bf2db95
Compare
bf2db95 to
4823bfa
Compare
4823bfa to
34212d7
Compare
34212d7 to
d37abda
Compare
alexrashed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this! Great to see the sync being decoupled to support the future strategy. I only added a few small questions, mostly because I might not fully understand how the release cycles and the upgrade path of LocalStack is going to look like in the future... 😅
| schedule: | ||
| - cron: 0 5 * * MON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: given that we do not have a schedule on the "sync" workflow anymore, does it make sense to have a weekly schedule on this one? Hopefully there won't be any commits in the repo in most weeks? Wouldn't this pipeline fail now if there are no commits fora whole week?
Or are there automated changes similar to #86 created by new automations strictly every single week?
| - name: Guess next version | ||
| id: semver | ||
| uses: "WyriHaximus/github-action-next-semvers@v1" | ||
| with: | ||
| version: ${{ steps.previous.outputs.tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: How is this version determined and what do we expect the next few version numbers to look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Does it make sense to even keep this pipeline? You mentioned in the description that there is no plan to sync the fork with upstream anymore? If this is the case, I guess we could just remove this part / this workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Might make sense to rename the workflows a bit. They don't have much to do with Continuous Integration anymore I guess 😅
Background
Moto-Ext current has an action that rebases the codebase with upstream repo and publishes the build to PyPI, introduced in #78.
Changes
Following the hard fork (see #83), Moto-Ext will not be rebased with the upstream repo. This PR therefore reworks this CI pipeline and splits it into two separate workflows:
Tests
Successful dry runs for:
Related
Closes: PNX-558