Add --verbose flag to bypass log filtering#140
Conversation
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM! Just some linting errors
cmd/logs.go
Outdated
| return container.Logs(cmd.Context(), rt, output.NewPlainSink(os.Stdout), appConfig.Containers, follow) | ||
| }), | ||
| return container.Logs(cmd.Context(), rt, output.NewPlainSink(os.Stdout), appConfig.Containers, follow, verbose) | ||
| }, |
There was a problem hiding this comment.
| }, | |
| }), |
carole-lavillonniere
force-pushed
the
carole/drg-589-2
branch
from
4edbe1e to
d31e771
Compare
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
carole-lavillonniere
force-pushed
the
carole/drg-589-2
branch
from
d58127f to
20b1038
Compare
|
Closed by accident |
3 participants
Motivation
The log filtering introduced in the previous PR hides noisy lines by default, but users may need to see all raw output for debugging. The
--verboseflag provides an escape hatch.Changes
--verbose/-vflag tolstk logsto bypass log filteringverboseparam throughcontainer.Logsandui.RunLogsTests
The filtering logic is already covered by unit tests in
internal/container/logfilter_test.go. The--verboseflag toggles the existingshouldFilterpredicate — no new logic to test.Towards DRG-589