Open
Conversation
whummer
reviewed
Feb 6, 2026
Member
There was a problem hiding this comment.
Very cool, kudos for adding this one @HarshCasper ! 🚀 I just checked out the branch and ran the sample - works like a charm. Nice to see that it also uses the Vault Lambda Extension layer, which nicely gets pulled into LocalStack. 👌
My only concern here is - hashicorp/vault is published under a BSL license, so we should first do another legal review before publishing this extension to our customers (ideally we'll get in touch with folks at HashiCorp to get them on board with this). Happy to discuss this offline. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary