-
Notifications
You must be signed in to change notification settings - Fork 133
Fix typo IRT translation from "ریال" to "تومان" #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the IRT (Iranian Toman) entry in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
util/fiat.json (1)
595-605: Approve the symbol change; recommend fixing the adjacent name typo.The change from "﷼" (Rial sign) to "تومان" (Persian word for Toman) is correct and aligns with the currency's official code. Using the native language representation is consistent with other entries in this file (e.g., "Lek" for ALL).
However, note that Line 597 contains
"name": "Iranian Tomen", which appears to be a spelling error for "Iranian Toman". This should also be corrected for consistency:- "name": "Iranian Tomen", + "name": "Iranian Toman",And the same correction should apply to Line 603:
- "name_plural": "Iranian Tomen", + "name_plural": "Iranian Toman",
mgatmiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix in line 598 is perfect. Also in line 597, the name should be "Iranian Toman"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
util/fiat.json (1)
603-603: Consider pluralizing "Toman" to "Tomans".The
name_pluralfield currently uses "Iranian Toman" (singular form). In English, "Toman" typically pluralizes to "Tomans". Most currencies in this file that naturally pluralize in English include the 's' (e.g., "US dollars", "British pounds sterling", "Pakistani rupees").🔎 Suggested pluralization
- "name_plural": "Iranian Toman", + "name_plural": "Iranian Tomans",
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
util/fiat.json
🔇 Additional comments (2)
util/fiat.json (2)
597-597: LGTM! Spelling correction is accurate.The typo fix from "Tomen" to "Toman" correctly reflects the standard English spelling of the Iranian currency.
Also applies to: 603-603
598-598: symbol_native representation is correct.The change to "تومان" (the Persian word for Toman) is the standard native representation. Unlike the Rial sign (﷼), there is no separate Unicode symbol for Toman; it is written as the word تومان after the amount in Persian. This representation aligns with how the currency is used in practice and is consistent with the file's pattern of using text abbreviations for symbol_native across multiple currencies.
commit for #702
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.