Skip to content

Conversation

@j2a1ck
Copy link

@j2a1ck j2a1ck commented Dec 31, 2025

commit for #702

Summary by CodeRabbit

  • Bug Fixes
    • Updated Iranian Toman currency display information, including correction of the currency name and native symbol representation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025

Walkthrough

The pull request updates the IRT (Iranian Toman) entry in util/fiat.json: the currency name and plural form changed from "Iranian Tomen" to "Iranian Toman", and the native symbol changed from "﷼" to the Persian word "تومان".

Changes

Cohort / File(s) Change Summary
Fiat Currency Configuration
util/fiat.json
Updated IRT fields: name and name_plural from "Iranian Tomen""Iranian Toman"; symbol_native from "﷼""تومان"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped through JSON, tidy and calm,
Found "Tomen" and nudged it to "Toman",
Swapped a symbol for "تومان" with cheer,
Now the file whispers the name true and clear. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions fixing a typo from 'ریال' to 'تومان' (Persian text), but the actual changes correct the English spelling from 'Tomen' to 'Toman' in name, symbol_native, and name_plural fields. The title could be clarified to accurately reflect that the changes correct English spelling ('Tomen' to 'Toman') rather than translating from 'ریال' to 'تومان'. Consider: 'Fix IRT currency name spelling from Tomen to Toman'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
util/fiat.json (1)

595-605: Approve the symbol change; recommend fixing the adjacent name typo.

The change from "﷼" (Rial sign) to "تومان" (Persian word for Toman) is correct and aligns with the currency's official code. Using the native language representation is consistent with other entries in this file (e.g., "Lek" for ALL).

However, note that Line 597 contains "name": "Iranian Tomen", which appears to be a spelling error for "Iranian Toman". This should also be corrected for consistency:

-    "name": "Iranian Tomen",
+    "name": "Iranian Toman",

And the same correction should apply to Line 603:

-    "name_plural": "Iranian Tomen",
+    "name_plural": "Iranian Toman",
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875ede4 and 02108b1.

📒 Files selected for processing (1)
  • util/fiat.json

Copy link

@mgatmiri mgatmiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix in line 598 is perfect. Also in line 597, the name should be "Iranian Toman"

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
util/fiat.json (1)

603-603: Consider pluralizing "Toman" to "Tomans".

The name_plural field currently uses "Iranian Toman" (singular form). In English, "Toman" typically pluralizes to "Tomans". Most currencies in this file that naturally pluralize in English include the 's' (e.g., "US dollars", "British pounds sterling", "Pakistani rupees").

🔎 Suggested pluralization
-    "name_plural": "Iranian Toman",
+    "name_plural": "Iranian Tomans",
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02108b1 and ec8090f.

📒 Files selected for processing (1)
  • util/fiat.json
🔇 Additional comments (2)
util/fiat.json (2)

597-597: LGTM! Spelling correction is accurate.

The typo fix from "Tomen" to "Toman" correctly reflects the standard English spelling of the Iranian currency.

Also applies to: 603-603


598-598: symbol_native representation is correct.

The change to "تومان" (the Persian word for Toman) is the standard native representation. Unlike the Rial sign (﷼), there is no separate Unicode symbol for Toman; it is written as the word تومان after the amount in Persian. This representation aligns with how the currency is used in practice and is consistent with the file's pattern of using text abbreviations for symbol_native across multiple currencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants