Fix code quality issues and add health check endpoints#3763
Open
yurekami wants to merge 1 commit intolm-sys:mainfrom
Open
Fix code quality issues and add health check endpoints#3763yurekami wants to merge 1 commit intolm-sys:mainfrom
yurekami wants to merge 1 commit intolm-sys:mainfrom
Conversation
- Fix duplicate function name bug in controller.py where `worker_api_get_status` was defined twice, causing the test_connection endpoint to shadow the worker status endpoint - Fix PEP 8 violation: use `is None` instead of `== None` in model_worker.py - Fix type comparison: use `isinstance()` instead of `type() ==` in openai_api_server.py for better Pythonic style - Add `/health` endpoint to both controller and openai_api_server for load balancer and orchestration system compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
controller.pywhereworker_api_get_statuswas defined twice, causing the/test_connectionendpoint handler to shadow the/worker_get_statusendpoint handleris Noneinstead of== Noneinmodel_worker.pyisinstance()instead oftype() ==inopenai_api_server.pyfor better Pythonic style/healthendpoint to both controller and openai_api_server for load balancer and orchestration system compatibility (e.g., Kubernetes liveness probes)Test plan
python -m py_compileon all modified files/healthendpoint returns{"status": "ok"}Details
Bug Fix: Duplicate Function Name
In
controller.py, the functionworker_api_get_statuswas defined twice:/worker_get_status/test_connectionThe second definition shadowed the first, which could cause issues. Renamed the second to
test_connection.Health Check Endpoints
Added simple
/healthendpoints that return{"status": "ok"}for:This is useful for:
🤖 Generated with Claude Code