Remove inf and denorm from f32tof16 input#996
Merged
joaosaffran merged 6 commits intollvm:mainfrom Mar 25, 2026
Merged
Conversation
joaosaffran
added
the
test-all
joaosaffran
changed the title
inbelic
approved these changes
Mar 24, 2026
test/Feature/HLSLLib/f32tof16.test
Outdated
Comment on lines
+61
to
+62
| # f32tof16 represents f16 in the lower half of resulting uint | ||
| Data: [ 0, 12288, 13312, 1024, 13653, 15359, 15360, 15361, 31743, 16968, 15360, 32768, 22080, 54848, 47768, 20800 ] |
Contributor
There was a problem hiding this comment.
I do think we should keep the hex values so it is easier to just take that and paste it to get a half representation.
While we are here though, maybe we could have a second output buffer of RWStructredBuffer OutHalf that we could check for clarity
Although I guess that means this test would require half, so perhaps not
Contributor
There was a problem hiding this comment.
+1 I think we should keep the hex values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes inf and denorms from f32tof16 calls and output. It also changes the expected output representation to not use hex
Fix: #984