Skip to content

Added WaveOps tests for QuadReadAcrossY#993

Merged
bob80905 merged 5 commits intollvm:mainfrom
kcloudy0717:kcloudy0717/QuadReadAcrossY
Mar 24, 2026
Merged

Added WaveOps tests for QuadReadAcrossY#993
bob80905 merged 5 commits intollvm:mainfrom
kcloudy0717:kcloudy0717/QuadReadAcrossY

Conversation

@kcloudy0717
Copy link
Copy Markdown
Contributor

PR for QuadReadAcrossY tests, resolves #883.

@kcloudy0717
Copy link
Copy Markdown
Contributor Author

Pinging @bob80905 and @farzonl for review.

Copy link
Copy Markdown
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I won't block on the nit, but it would be nice to update the comments on both readacross x / y

Copy link
Copy Markdown
Contributor

@bob80905 bob80905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there are test failures caused by read across Y. Please file the appropriate issues and add the XFAILS.

@kcloudy0717
Copy link
Copy Markdown
Contributor Author

Just realized there are test failures caused by read across Y. Please file the appropriate issues and add the XFAILS.

Will do. Usually I delay filling any XFAILs until reported by workflows, which requires someone from the team to approve the workflow runs.

I'll go over them and file appropriate issues. Thanks for the heads up.

@kcloudy0717 kcloudy0717 force-pushed the kcloudy0717/QuadReadAcrossY branch from a8ddf85 to f231a77 Compare March 20, 2026 15:07
@kcloudy0717
Copy link
Copy Markdown
Contributor Author

@bob80905 I updated tests with proper XFAILs. I do have one question: for the issues I reused the ones from QuadReadAcrossX because they are identical, do we want to create new issues or can we reuse the old ones?

@kcloudy0717 kcloudy0717 force-pushed the kcloudy0717/QuadReadAcrossY branch from 87a0524 to 119d7ae Compare March 23, 2026 18:02
@kcloudy0717 kcloudy0717 marked this pull request as ready for review March 23, 2026 18:04
@kcloudy0717 kcloudy0717 force-pushed the kcloudy0717/QuadReadAcrossY branch from 119d7ae to a4f0196 Compare March 23, 2026 18:16
@bob80905
Copy link
Copy Markdown
Contributor

@bob80905 I updated tests with proper XFAILs. I do have one question: for the issues I reused the ones from QuadReadAcrossX because they are identical, do we want to create new issues or can we reuse the old ones?

I think we can reuse the issue, though I would recommend editing the issue to include Y as well.

@kcloudy0717 kcloudy0717 force-pushed the kcloudy0717/QuadReadAcrossY branch from a4f0196 to 117684c Compare March 24, 2026 05:14
@kcloudy0717
Copy link
Copy Markdown
Contributor Author

@bob80905 Updated XFAILs and related github issues. This PR is good to go for me, whenever you're ready, feel free to merge.

@bob80905 bob80905 merged commit c865d62 into llvm:main Mar 24, 2026
12 checks passed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we might need to mark this as failing for WARP: https://github.com/llvm/offload-test-suite/actions/runs/23505742729.

Although interestingly, the pr checks seem to indicate that it was passing. grep for QuadReadAcrossY.fp64.test in the workflow logs.

It is thus not clear if the failure is intermittent or not

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, interesting. Either way I'll go ahead a file an issue and open a PR with XFAIL for this test. We can always close it later if it was intermittent .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue:#1013
PR: #1014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for QuadReadAcrossY

4 participants