Added WaveOps tests for QuadReadAcrossY#993
Conversation
bob80905
left a comment
There was a problem hiding this comment.
LGTM, I won't block on the nit, but it would be nice to update the comments on both readacross x / y
bob80905
left a comment
There was a problem hiding this comment.
Just realized there are test failures caused by read across Y. Please file the appropriate issues and add the XFAILS.
Will do. Usually I delay filling any XFAILs until reported by workflows, which requires someone from the team to approve the workflow runs. I'll go over them and file appropriate issues. Thanks for the heads up. |
a8ddf85 to
f231a77
Compare
|
@bob80905 I updated tests with proper XFAILs. I do have one question: for the issues I reused the ones from QuadReadAcrossX because they are identical, do we want to create new issues or can we reuse the old ones? |
87a0524 to
119d7ae
Compare
119d7ae to
a4f0196
Compare
I think we can reuse the issue, though I would recommend editing the issue to include Y as well. |
a4f0196 to
117684c
Compare
|
@bob80905 Updated XFAILs and related github issues. This PR is good to go for me, whenever you're ready, feel free to merge. |
There was a problem hiding this comment.
It looks like we might need to mark this as failing for WARP: https://github.com/llvm/offload-test-suite/actions/runs/23505742729.
Although interestingly, the pr checks seem to indicate that it was passing. grep for QuadReadAcrossY.fp64.test in the workflow logs.
It is thus not clear if the failure is intermittent or not
There was a problem hiding this comment.
Hmmm, interesting. Either way I'll go ahead a file an issue and open a PR with XFAIL for this test. We can always close it later if it was intermittent .
PR for
QuadReadAcrossYtests, resolves #883.