[DirectX] Add TypedBuffer 64-bit load/store tests#990
Merged
Conversation
kmpeng
added
the
test-all
kmpeng
commented
Mar 18, 2026
kmpeng
commented
Mar 18, 2026
inbelic
reviewed
Mar 18, 2026
farzonl
approved these changes
Mar 24, 2026
Member
farzonl
left a comment
farzonl
left a comment
There was a problem hiding this comment.
This change looks fine to me, but i'm a little concerned that you are marking vulkan as unsupported. I think you have a layout issue. In anycase since my change that you are testing was specific to the DX backend I'm approving.
bogner
reviewed
Mar 25, 2026
Contributor
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
Can we also get some test coverage for reading from an RWBuffer and for buffers that have a single int64_t/uint64_t rather than int64_t2/uint64_t2?
kmpeng
commented
Mar 26, 2026
llvm-beanz
reviewed
Mar 30, 2026
tex3d
reviewed
Mar 30, 2026
tex3d
approved these changes
Mar 31, 2026
llvm-beanz
approved these changes
Mar 31, 2026
llvm-beanz
pushed a commit
to llvm-beanz/offload-test-suite
that referenced
this pull request
Apr 7, 2026
Closes llvm#275. Adds 64-bit tests for `TypedBuffer` load/stores testing `int64_t` and `uint64_t`. It only tests scalars and vectors of 2 since those are the sizes supported for these types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #275.
Adds 64-bit tests for
TypedBufferload/stores testingint64_tanduint64_t. It only tests scalars and vectors of 2 since those are the sizes supported for these types.