Split texture2d OperatorIndex test in two.#958
Merged
Conversation
The Texture2D.OperatorIndex.test.yaml has tests for both operator[] and the mips member. They should be separate tests. We also enable the Vulkan clang versions of the test. They should be passing now.
farzonl
approved these changes
Apr 1, 2026
inbelic
approved these changes
Apr 1, 2026
Contributor
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM once we incorperate the changes from https://github.com/llvm/offload-test-suite/pull/1036/changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Texture2D.OperatorIndex.test.yaml has tests for both operator[] and
the mips member. They should be separate tests.
Enable passing Texture2D tests that are passing with clang vulkan.