[SPIR-V] Support vk::SampledTexture2D in offload test suite.#748
Merged
[SPIR-V] Support vk::SampledTexture2D in offload test suite.#748
vk::SampledTexture2D in offload test suite.#748Conversation
Keenuts
reviewed
Feb 19, 2026
luciechoi
force-pushed
the
sampledtexture
branch
from
095f5c4 to
8e04278
Compare
s-perron
reviewed
Mar 23, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
I have a few questions, without strong opinions. Let me know what you think
luciechoi
force-pushed
the
sampledtexture
branch
from
9aafbe7 to
4f28253
Compare
luciechoi
force-pushed
the
sampledtexture
branch
from
4f28253 to
22f86c9
Compare
s-perron
reviewed
Mar 30, 2026
Contributor
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
This looks pretty good. Just a couple things:
- Why move the SamplerComparision kind to the Sampler? I don't have a strong feeling either way, but I'd like to reduce churn if possible. If there is a good reason, we can do it.
- Document how the sampled textured work in https://github.com/llvm/offload-test-suite/tree/main/docs.
luciechoi
force-pushed
the
sampledtexture
branch
from
a68fe7a to
7ad7fad
Compare
luciechoi
commented
Mar 31, 2026
luciechoi
force-pushed
the
sampledtexture
branch
from
7ad7fad to
9cc7ac7
Compare
s-perron
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SampledTexture2Dresource type..Sample()forvk::SampledTexture2D.SamplerComparisona Sampler type not a pipeline resource type.The test is exactly the same as Texture2D.Sample.test.yaml.
Part of microsoft/DirectXShaderCompiler#7979