Skip to content

Add tests for WaveActiveMin#478

Open
KungFuDonkey wants to merge 4 commits intollvm:mainfrom
KungFuDonkey:kfd/WaveActiveMinTests
Open

Add tests for WaveActiveMin#478
KungFuDonkey wants to merge 4 commits intollvm:mainfrom
KungFuDonkey:kfd/WaveActiveMinTests

Conversation

@KungFuDonkey
Copy link
Copy Markdown

@KungFuDonkey KungFuDonkey commented Oct 21, 2025

Adds tests for WaveActiveMin, based on the WaveActiveMax tests in #429

I generated the results using a python script, but I cannot figure out how to run the tests. Any guidance on that would help

@KungFuDonkey KungFuDonkey mentioned this pull request Oct 21, 2025
Merged
12 tasks
@llvm-beanz
Copy link
Copy Markdown
Collaborator

llvm-beanz commented Oct 26, 2025

The tests look reasonable to me. I've kicked them to the CI to run.

@KungFuDonkey
Copy link
Copy Markdown
Author

KungFuDonkey commented Oct 26, 2025

It complains about WaveActiveMin not existing, which is currently true as the WaveActiveMin PR is not in. Did I miss something that should make this expectedly fail?

E:\actions-runner\_work\offload-test-suite\offload-test-suite\llvm-project\build\tools\OffloadTest\test\clang-d3d12\WaveOps\Output\WaveActiveMin.test.tmp/source.hlsl:8:21: error: use of undeclared identifier 'WaveActiveMin'; did you mean 'WaveActiveMax'?
# |     8 |   Nans[TID.x % 8] = WaveActiveMin(Nans[TID.x % 8]);
# |       |                     ^~~~~~~~~~~~~
# |       |                     WaveActiveMax

bob80905 pushed a commit to llvm/llvm-project that referenced this pull request Oct 28, 2025
@KungFuDonkey
[HLSL][DXIL][SPRIV] Added WaveActiveMin intrinsic (#164385)
bfd4935 
Adds the WaveActiveMin intrinsic from #99169. I think I did all of the
required things on the checklist:
- [x]  Implement `WaveActiveMin` clang builtin,
- [x]  Link `WaveActiveMin` clang builtin with `hlsl_intrinsics.h`
- [x] Add sema checks for `WaveActiveMin` to
`CheckHLSLBuiltinFunctionCall` in `SemaChecking.cpp`
- [x] Add codegen for `WaveActiveMin` to `EmitHLSLBuiltinExpr` in
`CGBuiltin.cpp`
- [x] Add codegen tests to
`clang/test/CodeGenHLSL/builtins/WaveActiveMin.hlsl`
- [x] Add sema tests to
`clang/test/SemaHLSL/BuiltIns/WaveActiveMin-errors.hlsl`
- [x] Create the `int_dx_WaveActiveMin` intrinsic in
`IntrinsicsDirectX.td`
- [x] Create the `DXILOpMapping` of `int_dx_WaveActiveMin` to `119` in
`DXIL.td`
- [x] Create the `WaveActiveMin.ll` and `WaveActiveMin_errors.ll` tests
in `llvm/test/CodeGen/DirectX/`
- [x] Create the `int_spv_WaveActiveMin` intrinsic in
`IntrinsicsSPIRV.td`
- [x] In SPIRVInstructionSelector.cpp create the `WaveActiveMin`
lowering and map it to `int_spv_WaveActiveMin` in
`SPIRVInstructionSelector::selectIntrinsic`.
- [x] Create SPIR-V backend test case in
`llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveActiveMin.ll

But as some of the code has changed and was moved around (E.G.
`CGBuiltin.cpp` -> `CGHLSLBuiltins.cpp`) I mostly followed how
`WaveActiveMax()` is implemented.

I have not been able to run the tests myself as I am unsure which
project runs the correct test. Any guidance on how I can test myself
would be helpful.

Also added some tests to the offload-test-suite
llvm/offload-test-suite#478
llvm-sync Bot pushed a commit to arm/arm-toolchain that referenced this pull request Oct 28, 2025
@KungFuDonkey @github-actions
Automerge: [HLSL][DXIL][SPRIV] Added WaveActiveMin intrinsic (#164385)
cffcc12 
Adds the WaveActiveMin intrinsic from #99169. I think I did all of the
required things on the checklist:
- [x]  Implement `WaveActiveMin` clang builtin,
- [x]  Link `WaveActiveMin` clang builtin with `hlsl_intrinsics.h`
- [x] Add sema checks for `WaveActiveMin` to
`CheckHLSLBuiltinFunctionCall` in `SemaChecking.cpp`
- [x] Add codegen for `WaveActiveMin` to `EmitHLSLBuiltinExpr` in
`CGBuiltin.cpp`
- [x] Add codegen tests to
`clang/test/CodeGenHLSL/builtins/WaveActiveMin.hlsl`
- [x] Add sema tests to
`clang/test/SemaHLSL/BuiltIns/WaveActiveMin-errors.hlsl`
- [x] Create the `int_dx_WaveActiveMin` intrinsic in
`IntrinsicsDirectX.td`
- [x] Create the `DXILOpMapping` of `int_dx_WaveActiveMin` to `119` in
`DXIL.td`
- [x] Create the `WaveActiveMin.ll` and `WaveActiveMin_errors.ll` tests
in `llvm/test/CodeGen/DirectX/`
- [x] Create the `int_spv_WaveActiveMin` intrinsic in
`IntrinsicsSPIRV.td`
- [x] In SPIRVInstructionSelector.cpp create the `WaveActiveMin`
lowering and map it to `int_spv_WaveActiveMin` in
`SPIRVInstructionSelector::selectIntrinsic`.
- [x] Create SPIR-V backend test case in
`llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveActiveMin.ll

But as some of the code has changed and was moved around (E.G.
`CGBuiltin.cpp` -> `CGHLSLBuiltins.cpp`) I mostly followed how
`WaveActiveMax()` is implemented.

I have not been able to run the tests myself as I am unsure which
project runs the correct test. Any guidance on how I can test myself
would be helpful.

Also added some tests to the offload-test-suite
llvm/offload-test-suite#478
DEBADRIBASAK pushed a commit to DEBADRIBASAK/llvm-project that referenced this pull request Nov 3, 2025
@KungFuDonkey
[HLSL][DXIL][SPRIV] Added WaveActiveMin intrinsic (llvm#164385)
dfc1ada 
Adds the WaveActiveMin intrinsic from llvm#99169. I think I did all of the
required things on the checklist:
- [x]  Implement `WaveActiveMin` clang builtin,
- [x]  Link `WaveActiveMin` clang builtin with `hlsl_intrinsics.h`
- [x] Add sema checks for `WaveActiveMin` to
`CheckHLSLBuiltinFunctionCall` in `SemaChecking.cpp`
- [x] Add codegen for `WaveActiveMin` to `EmitHLSLBuiltinExpr` in
`CGBuiltin.cpp`
- [x] Add codegen tests to
`clang/test/CodeGenHLSL/builtins/WaveActiveMin.hlsl`
- [x] Add sema tests to
`clang/test/SemaHLSL/BuiltIns/WaveActiveMin-errors.hlsl`
- [x] Create the `int_dx_WaveActiveMin` intrinsic in
`IntrinsicsDirectX.td`
- [x] Create the `DXILOpMapping` of `int_dx_WaveActiveMin` to `119` in
`DXIL.td`
- [x] Create the `WaveActiveMin.ll` and `WaveActiveMin_errors.ll` tests
in `llvm/test/CodeGen/DirectX/`
- [x] Create the `int_spv_WaveActiveMin` intrinsic in
`IntrinsicsSPIRV.td`
- [x] In SPIRVInstructionSelector.cpp create the `WaveActiveMin`
lowering and map it to `int_spv_WaveActiveMin` in
`SPIRVInstructionSelector::selectIntrinsic`.
- [x] Create SPIR-V backend test case in
`llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveActiveMin.ll

But as some of the code has changed and was moved around (E.G.
`CGBuiltin.cpp` -> `CGHLSLBuiltins.cpp`) I mostly followed how
`WaveActiveMax()` is implemented.

I have not been able to run the tests myself as I am unsure which
project runs the correct test. Any guidance on how I can test myself
would be helpful.

Also added some tests to the offload-test-suite
llvm/offload-test-suite#478
spall
spall reviewed Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@spall spall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newlines to the files missing them at the end.
And it looks like WaveActiveMin.test is missing the XFAIL: Clang.

@KungFuDonkey
Copy link
Copy Markdown
Author

KungFuDonkey commented Nov 22, 2025

add newlines to the files missing them at the end. And it looks like WaveActiveMin.test is missing the XFAIL: Clang.

Thanks for the suggestion! I updated the branch, so it should be ready now

spall
spall reviewed Nov 24, 2025
View reviewed changes
Comment thread test/WaveOps/WaveActiveMin.test
# DirectX driver implementations seem to match SPIR-V, except WARP, which does
# not treat -INF as an identity.

# XFAIL: Clang && DirectX && WARP
Copy link
Copy Markdown
Contributor

@spall spall Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to move this xfail above the run lines. I think its being ignored where it is.

Icohedron
Icohedron reviewed Dec 18, 2025
View reviewed changes
Comment thread test/WaveOps/WaveActiveMin.fp64.test

# Bug https://github.com/llvm/offload-test-suite/issues/393
# XFAIL: Metal

Copy link
Copy Markdown
Contributor

@Icohedron Icohedron Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# REQUIRES: Double

Icohedron
Icohedron reviewed Dec 18, 2025
View reviewed changes
Comment thread test/WaveOps/WaveActiveMin.fp16.test

# Bug https://github.com/llvm/offload-test-suite/issues/393
# XFAIL: Metal

Copy link
Copy Markdown
Contributor

@Icohedron Icohedron Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# REQUIRES: Half

Icohedron
Icohedron reviewed Dec 18, 2025
View reviewed changes
Comment thread test/WaveOps/WaveActiveMin.int16.test

# Bug https://github.com/llvm/offload-test-suite/issues/393
# XFAIL: Metal

Copy link
Copy Markdown
Contributor

@Icohedron Icohedron Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# REQUIRES: Int16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spall spall spall left review comments

@Icohedron Icohedron Icohedron left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KungFuDonkey @llvm-beanz @spall @Icohedron @bogner