[clang-tidy][NFC] Remove obsolete FIXME comment #172120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) ChangesThis comment was written 12 years ago. It's no longer correct to say that diagnostic reporting is under heavy development, and we seem to be doing just fine without tablegenned IDs, so I think we can simply remove it. Full diff: https://github.com/llvm/llvm-project/pull/172120.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
index 21ffd9de35c19..8de5778dfefb0 100644
--- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
+++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
@@ -91,10 +91,6 @@ class ClangTidyContext {
ClangTidyContext &operator=(const ClangTidyContext &) = delete;
/// Report any errors detected using this method.
- ///
- /// This is still under heavy development and will likely change towards using
- /// tablegen'd diagnostic IDs.
- /// FIXME: Figure out a way to manage ID spaces.
DiagnosticBuilder diag(StringRef CheckName, SourceLocation Loc,
StringRef Description,
DiagnosticIDs::Level Level = DiagnosticIDs::Warning);
|
zeyi2
approved these changes
Dec 13, 2025
vbvictor
reviewed
Dec 13, 2025
Contributor
vbvictor
left a comment
vbvictor
left a comment
There was a problem hiding this comment.
If clang gets SARIF diagnostics in the future, maybe clang-tidy will adapt to it soon too (see https://discourse.llvm.org/t/rfc-emitting-auditable-sarif-logs-from-clang/88624).
But I guess it's okay to remove fixme for now
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/13564 Here is the relevant piece of the build log for the reference |
anonymouspc
pushed a commit
to anonymouspc/llvm
that referenced
this pull request
Dec 15, 2025
This comment was written 12 years ago. It's no longer correct to say that diagnostic reporting is under heavy development, and we seem to be doing just fine without tablegenned IDs, so I think we can simply remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was written 12 years ago. It's no longer correct to say that diagnostic reporting is under heavy development, and we seem to be doing just fine without tablegenned IDs, so I think we can simply remove it.