Skip to content

[flang] restrict fir.convert lowering #172117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SusanTan merged 3 commits into from
Dec 15, 2025
Merged

[flang] restrict fir.convert lowering #172117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c5715
change upstream conversion
SusanTan Dec 12, 2025
6b7513b
add test
SusanTan Dec 13, 2025
800b110
delete braces
SusanTan Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions flang/lib/Optimizer/CodeGen/CodeGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,6 +816,15 @@ struct ConvertOpConversion : public fir::FIROpConversion<fir::ConvertOp> {
mlir::ConversionPatternRewriter &rewriter) const override {
auto fromFirTy = convert.getValue().getType();
auto toFirTy = convert.getRes().getType();

// Let more specialized conversions (e.g. FIR to memref
// converters) handle fir.convert when either side is a memref. This
// avoids interfering with descriptor-based flows such as fir.box /
// fir.box_addr and keeps this pattern focused on value conversions.
if (mlir::isa<mlir::MemRefType>(fromFirTy) ||
mlir::isa<mlir::MemRefType>(toFirTy))
return mlir::failure();

auto fromTy = convertType(fromFirTy);
auto toTy = convertType(toFirTy);
mlir::Value op0 = adaptor.getOperands()[0];
Expand Down
15 changes: 15 additions & 0 deletions flang/test/Fir/convert-memref-codegen.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: not fir-opt --fir-to-llvm-ir="target=x86_64-unknown-linux-gnu" %s -o - 2>&1 | FileCheck %s

// This test ensures that the FIR CodeGen ConvertOpConversion
// rejects fir.convert when either the source or the destination
// type is a memref (i.e. it fails to legalize those ops).

module {
// CHECK: error: failed to legalize operation 'fir.convert'
func.func @memref_to_ref_convert(%arg0: memref<f32>) {
%0 = fir.convert %arg0 : (memref<f32>) -> !fir.ref<f32>
return
}
}