[flang][NFC] Document an intentional violation of the ISO standard #172105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneepshteyn
approved these changes
Dec 14, 2025
tarunprabhu
approved these changes
Dec 14, 2025
Contributor
tarunprabhu
left a comment
tarunprabhu
left a comment
There was a problem hiding this comment.
Just a couple of suggestions.
flang/docs/Extensions.md
Outdated
| the same way as the static presence or absence of the argument does | ||
| at compilation time, which would not be possible.) | ||
| No compiler seems to enforce this requirement, and we interpret it | ||
| to mean that a`OPTIONAL` dummy argument may appear but must be present |
Contributor
There was a problem hiding this comment.
Suggested change
| to mean that a`OPTIONAL` dummy argument may appear but must be present | |
| to mean that an `OPTIONAL` dummy argument may appear, but must be present |
flang/docs/Extensions.md
Outdated
| presence at runtime could affect the semantics of the intrinsic in | ||
| the same way as the static presence or absence of the argument does | ||
| at compilation time, which would not be possible.) | ||
| No compiler seems to enforce this requirement, and we interpret it |
Contributor
There was a problem hiding this comment.
Suggested change
| No compiler seems to enforce this requirement, and we interpret it | |
| No compiler seems to enforce this requirement. We interpret it |
This compiler (like all others) allows OPTIONAL dummy arguments to appear as arguments to some intrinsic functions that are specified as disallowing them; document this interpretation better.
| the same way as the static presence or absence of the argument does | ||
| at compilation time, which would not be possible.) | ||
| No compiler seems to enforce this requirement. | ||
| We interpret it |
Contributor
There was a problem hiding this comment.
Strange line break?
tarunprabhu
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiler (like all others) allows OPTIONAL dummy arguments to appear as arguments to some intrinsic functions that are specified as disallowing them; document this interpretation better.