[WIP] Improve testing robustness#4
Open
stanciuadrian wants to merge 2 commits intolluchs:masterfrom
stanciuadrian:ImproveTestingRobustness
Open
[WIP] Improve testing robustness#4stanciuadrian wants to merge 2 commits intolluchs:masterfrom stanciuadrian:ImproveTestingRobustness
stanciuadrian wants to merge 2 commits intolluchs:masterfrom
stanciuadrian:ImproveTestingRobustness
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP headers are case insensitive and so should the comparisons be. The lowercase version of the expected headers are compared with the lowercase version of the received ones.
WIP: Updated
reqwestversion in test to0.8.8(latest available on0.8.*. It would be interesting to remove the package version from the tests and I am trying to fix this too.