Skip to content

Conversation

@pblazej
Copy link
Contributor

@pblazej pblazej commented Jan 28, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@pblazej
Copy link
Contributor Author

pblazej commented Jan 28, 2026

@ladvoc here we need to resolve the panic for tier3

error[E0463]: can't find crate for `panic_abort`

BTW, tvOS and visionOS will be promoted soon to tier2

@pblazej pblazej requested a review from ladvoc February 2, 2026 07:27
Copy link
Contributor

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅, feel free to merge

@ladvoc
Copy link
Contributor

ladvoc commented Feb 2, 2026

Linking this here for reference: mozilla/uniffi-rs#2802

@pblazej
Copy link
Contributor Author

pblazej commented Feb 5, 2026

This is due to a bug in cargo-swift btw, I'm trying to fix it there and remove "manual postprocessing".

@pblazej
Copy link
Contributor Author

pblazej commented Feb 6, 2026

Should be fixed by antoniusnaumann/cargo-swift#87 once used

@pblazej pblazej closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants