adding ability to control local video track encode parameters#1136
Open
chenosaurus wants to merge 1 commit into
Open
adding ability to control local video track encode parameters#1136chenosaurus wants to merge 1 commit into
chenosaurus wants to merge 1 commit into
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
ladvoc
approved these changes
Jun 5, 2026
| } | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| struct SetEncodingLimitsRequest { |
Contributor
There was a problem hiding this comment.
suggestion: Consider putting common structs in a module and share between the two binaries.
cloudwebrtc
approved these changes
Jun 5, 2026
| self.sys_handle | ||
| .set_parameters(parameters.into()) | ||
| .set_parameters(native_parameters) | ||
| .map_err(|e| unsafe { sys_err::ffi::RtcError::from(e.what()).into() }) |
Contributor
There was a problem hiding this comment.
what do these params mean for simulcast, adaptive streaming, and dynacast ?
| const SET_VIDEO_ENCODING_LIMITS_METHOD: &str = "set-video-encoding-limits"; | ||
|
|
||
| #[derive(Debug, Deserialize, Serialize)] | ||
| struct SetEncodingLimitsRequest { |
Contributor
There was a problem hiding this comment.
is this designed to cap this track overall ? or we should consider per encoding / layer limits due to simulcast ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.