Conversation
real-danm
reviewed
Apr 8, 2026
| sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect | ||
| ) | ||
|
|
||
| replace github.com/livekit/server-sdk-go/v2 => /Users/syoon/src/server-sdk-go |
Contributor
There was a problem hiding this comment.
saw your note, just another reminder
real-danm
reviewed
Apr 8, 2026
| k8s.io/apimachinery v0.34.1 | ||
| ) | ||
|
|
||
| replace github.com/livekit/protocol => /Users/syoon/src/protocol |
real-danm
approved these changes
Apr 8, 2026
Contributor
real-danm
left a comment
real-danm
left a comment
There was a problem hiding this comment.
lgtm, will the block a release until server side is ready? have to coordinate the rollout if so
| Name: "env", | ||
| Usage: "Deployment environment(s). For create/deploy, specifies the target environment (defaults to 'production'). For update-secrets, assigns environment(s) to the secret. Can be specified multiple times (e.g. --env staging --env production).", | ||
| Required: false, | ||
| } |
There was a problem hiding this comment.
Why only create/deploy/update-secrets? What about other rpc like status/update?
Can an agent (identified by unique agent_id) be in both Staging and Prod ? or only one env at any time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--envflag tocreate,destroyandupdate-secretscommands.production.TODO: remove
replacedirective ingo.modonce protocol changes are merged.ref AP-638