Skip to content

Expose draining status#765

Open
andrewnitu wants to merge 1 commit intomainfrom
andrewnitu/draining-status
Open

Expose draining status#765
andrewnitu wants to merge 1 commit intomainfrom
andrewnitu/draining-status

Conversation

@andrewnitu
Copy link
Contributor

@andrewnitu andrewnitu commented Feb 6, 2026

Summary by CodeRabbit

  • New Features
    • Agent versions table now displays a new "Draining" column, showing the draining status of each agent for improved visibility.

@andrewnitu andrewnitu changed the title draining Expose draining status Feb 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Added a new "Draining" column to the agent versions table display in the CLI tool. The column header is positioned after "Current" and each row now outputs the version.Draining value. No changes to sorting or display logic.

Changes

Cohort / File(s) Summary
Agent Version Table Display
cmd/lk/agent.go
Added "Draining" column to agent versions table. Column header inserted after "Current" and version.Draining field displayed in each row output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A draining column now appears with grace,
In agent versions' table space,
New field displayed for all to see,
Simple change, clear as can be! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Expose draining status' directly summarizes the main change: adding a Draining column to display draining status in the agent versions table.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch andrewnitu/draining-status

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d2c980 and 8fb22d7.

📒 Files selected for processing (1)
  • cmd/lk/agent.go
🧰 Additional context used
🪛 GitHub Actions: Build
cmd/lk/agent.go

[error] 1023-1023: Static analysis/Go compile error: version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

🪛 GitHub Check: build
cmd/lk/agent.go

[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)


[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

🪛 GitHub Check: test (ubuntu-latest)
cmd/lk/agent.go

[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)


[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (windows-latest)
  • GitHub Check: Analyze (go)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
cmd/lk/agent.go (1)

1012-1027: ⚠️ Potential issue | 🔴 Critical

Compile error: version.Draining does not exist on *livekit.AgentVersion.

The Draining field is not present on AgentVersion in the protocol library (v1.44.1-0.20260120134243-0914cc74653e). The type only has: version, status, owner, created_at, deployed_at, current, and attributes. Before this change can compile, you must either:

  1. Update the github.com/livekit/protocol dependency to a version that includes the Draining field, or
  2. Remove the Draining header (line 1013) and field reference (line 1023) if it is not yet available upstream.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d2c980 and 8fb22d7.

📒 Files selected for processing (1)
  • cmd/lk/agent.go
🧰 Additional context used
🪛 GitHub Actions: Build
cmd/lk/agent.go

[error] 1023-1023: Static analysis/Go compile error: version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

🪛 GitHub Check: build
cmd/lk/agent.go

[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)


[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

🪛 GitHub Check: test (ubuntu-latest)
cmd/lk/agent.go

[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)


[failure] 1023-1023:
version.Draining undefined (type *livekit.AgentVersion has no field or method Draining) (compile)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (windows-latest)
  • GitHub Check: Analyze (go)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant