Skip to content

Fix missing offer in syncState #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroshihorie merged 2 commits into from
Mar 17, 2026
Merged

Fix missing offer in syncState #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b89c4bd
fix
hiroshihorie Mar 16, 2026
3c2005d
changes
hiroshihorie Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/fix-syncstate-offer
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Include last server offer in SyncState during reconnection"
2 changes: 2 additions & 0 deletions lib/src/core/engine.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1231,6 +1231,7 @@ class Engine extends Disposable with EventsEmittable<EngineEvent> {
required List<String> trackSidsDisabled,
}) async {
final previousAnswer = (await subscriber?.pc.getLocalDescription())?.toPBType();
final previousOffer = (await subscriber?.pc.getRemoteDescription())?.toPBType();

// Build data channel receive states for reliability
final dataChannelReceiveStates = <lk_rtc.DataChannelReceiveState>[];
Expand All @@ -1245,6 +1246,7 @@ class Engine extends Disposable with EventsEmittable<EngineEvent> {
}
signalClient.sendSyncState(
answer: previousAnswer,
offer: previousOffer,
subscription: subscription,
publishTracks: publishTracks,
dataChannelInfo: dataChannelInfo(),
Expand Down
2 changes: 2 additions & 0 deletions lib/src/core/signal_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ extension SignalClientRequests on SignalClient {
@internal
void sendSyncState({
required lk_rtc.SessionDescription? answer,
required lk_rtc.SessionDescription? offer,
required lk_rtc.UpdateSubscription subscription,
required Iterable<lk_rtc.TrackPublishedResponse>? publishTracks,
required Iterable<lk_rtc.DataChannelInfo>? dataChannelInfo,
Expand All @@ -494,6 +495,7 @@ extension SignalClientRequests on SignalClient {
_sendRequest(lk_rtc.SignalRequest(
syncState: lk_rtc.SyncState(
answer: answer,
offer: offer,
subscription: subscription,
publishTracks: publishTracks,
dataChannels: dataChannelInfo,
Expand Down
Loading