Skip to content

Conversation

@xianshijing-lk
Copy link
Collaborator

The PR does:

  • Fixed the CMakelist.txt to make it compilable
  • Fixed README.md
  • Fixed the example
  • Added build.sh to make it easier to clean | build

@ladvoc
Copy link

ladvoc commented Nov 6, 2025

@xianshijing-lk, it looks like the CI workflow doesn't work anymore—should we address that here or in a separate PR? Also, I see this repo builds the Rust SDK from source rather than pulling in a prebuilt dylib. Do you have any thoughts on which you prefer?

@xianshijing-lk
Copy link
Collaborator Author

@xianshijing-lk, it looks like the CI workflow doesn't work anymore—should we address that here or in a separate PR? Also, I see this repo builds the Rust SDK from source rather than pulling in a prebuilt dylib. Do you have any thoughts on which you prefer?

I added the CI since I think that should be easily done, but the Linux bot is more complicated than I thought. And it looks like the last patch gets the bot running.

The current solution builds a static liblivekit-ffi.a and can be linked to any executable target. C++ Is a build from source world, lots of project might require building the code from source unless the code is too large or complex.

But I do think we probably want to use a pre-built liblivekit-ffi.a here, as it simplies the problems of building Rust and WebRTC

Copy link

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@xianshijing-lk xianshijing-lk merged commit d9e8076 into main Nov 7, 2025
3 checks passed
@xianshijing-lk xianshijing-lk deleted the sxian/CLT-2226/revive_client-sdk-cpp branch November 7, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants