Skip to content

Conversation

@xianshijing-lk
Copy link
Collaborator

@xianshijing-lk xianshijing-lk commented Dec 15, 2025

ffi_client.h and ffi_client.cpp are all internal implementation, so we should just move ffi_client.h to src/ folder

Copy link

@ladvoc ladvoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@xianshijing-lk
Copy link
Collaborator Author

Thanks Jacob

@xianshijing-lk xianshijing-lk merged commit 0484c7c into main Dec 15, 2025
5 checks passed
@xianshijing-lk xianshijing-lk deleted the sxian/CLT-2361/move_ffi_client_h_out_of_include_livekit_folder branch December 15, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants