Sxian/clt 2342/implement the remaining room events #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h, and fix the comments
ladvoc
approved these changes
Dec 11, 2025
include/livekit/room_event_types.h
Outdated
| /** | ||
| * A chat message associated with the room. | ||
| */ | ||
| struct ChatMessageData { |
There was a problem hiding this comment.
note: Chat messages are deprecated in favor of data streams. Not sure if we want to expose in new code.
Collaborator
Author
There was a problem hiding this comment.
Good find, I removed all the code related to ChatMessageData, as it is a deprecated feature, we shouldn't ship it.
| return out; | ||
| } | ||
|
|
||
| proto::TranscriptionReceived toProto(const Transcription &in) { |
Collaborator
Author
There was a problem hiding this comment.
how about TranscriptionSegment ?
xianshijing-lk
deleted the
sxian/CLT-2342/implement_the_remaining_room_events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the remaining room events
and separate the room_event_types.h and room_delegate.h
It also adds the comments / docs to the room_delegates.h and room_event_types.h