perf: skip Klaxon parsing for empty agent attribute maps #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 02df2e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
YashJainSC
force-pushed
the
perf/empty-map-early-return
branch
2 times, most recently
from
cf87af9 to
9dc6620
Compare
davidliu
reviewed
Jan 15, 2026
livekit-android-sdk/src/main/java/io/livekit/android/room/types/AgentTypesExt.kt
Outdated
Show resolved
Hide resolved
YashJainSC
force-pushed
the
perf/empty-map-early-return
branch
2 times, most recently
from
2678c19 to
dc35c96
Compare
YashJainSC
force-pushed
the
perf/empty-map-early-return
branch
from
dc35c96 to
02df2e6
Compare
davidliu
approved these changes
Jan 15, 2026
Contributor
|
LGTM! I think I'll also switch to kotlinx serialization here asap. Didn't think the first start time for klaxon was this drastic. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AgentAttributes.fromStringMap()was very slow on very first invocation for empty maps taking upto 1 seconds in some cases.Solution
Add early return when the input map is empty, returning a default
AgentAttributes()directly. This avoids triggering Klaxon parsingwhen there's nothing to parse.