fix(cli): restore terminal settings on console exit#6046
Open
kamalmostafa wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
In console mode the key-listener runs in a daemon thread that puts the tty into no-echo mode. Ctrl-C tears down the process -- commonly while the key-listener is in mid-read so its per-read restore never gets to run. The terminal is then left with echo disabled upon process exit. Fix: Snapshot the tty settings at the start of _run_console and restore them in its finally, which always runs in the main thread on exit, regardless of what state the listener thread might leave the terminal in. Fixes livekit#6045 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kamalmostafa
force-pushed
the
kamalmostafa/restore-console-tty-on-exit
branch
from
ec167f2 to
20a3a5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In console mode the key-listener runs in a daemon thread that puts the tty into no-echo mode. Ctrl-C tears down the process -- commonly while the key-listener is in mid-read so its per-read restore never gets to run.
The terminal is then left with echo disabled upon process exit.
Fix: Snapshot the tty settings at the start of _run_console and restore them in its finally, which always runs in the main thread on exit, regardless of what state the listener thread might leave the terminal in.
Fixes #6045