fix(ipc): hint about missing Git LFS on prewarm init failure#6044
Open
kamalmostafa wants to merge 1 commit into
Open
fix(ipc): hint about missing Git LFS on prewarm init failure#6044kamalmostafa wants to merge 1 commit into
kamalmostafa wants to merge 1 commit into
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
If the repo is cloned without Git LFS, the LFS-tracked assets (e.g. the Silero VAD model) are left as pointer placeholder files. This breaks even the basic examples, which crash with a cryptic error, e.g. onnxruntime.capi.onnxruntime_pybind11_state.InvalidProtobuf: [ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from .../livekit-plugins/livekit-plugins-silero/livekit/plugins/silero/resources/silero_vad.onnx failed:Protobuf parsing failed. Wrap the prewarm/init failure in _ProcClient.initialize() to append a hint suggesting the repo may have been cloned without Git LFS and instructions to resolve. Also document the Git LFS requirement in the README dev setup section. Fixes livekit#6043 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kamalmostafa
force-pushed
the
kamalmostafa/add-git-lfs-hint
branch
from
b72e402 to
7552644
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the repo is cloned without Git LFS, the LFS-tracked assets (e.g. the Silero VAD model) are left as pointer placeholder files. This breaks even the basic examples, which crash with a cryptic error, e.g.
onnxruntime.capi.onnxruntime_pybind11_state.InvalidProtobuf: [ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from .../livekit-plugins/livekit-plugins-silero/livekit/plugins/silero/resources/silero_vad.onnx failed:Protobuf parsing failed.
Wrap the prewarm/init failure in _ProcClient.initialize() to append a hint suggesting the repo may have been cloned without Git LFS and instructions to resolve. Also document the Git LFS requirement in the README dev setup section.
Fixes #6043