Add 2 more buttons to XP-Pen Artist 12#960
Draft
redstrate wants to merge 1 commit intolinuxwacom:masterfrom
Draft
Add 2 more buttons to XP-Pen Artist 12#960redstrate wants to merge 1 commit intolinuxwacom:masterfrom
redstrate wants to merge 1 commit intolinuxwacom:masterfrom
Conversation
We emulate the touch bar as two additional buttons for this tablet.
Contributor
Author
|
For some reason KDE Plasma is showing 3 buttons, this is probably our bug but I should look into it. |
Contributor
Author
|
It also looks like the SVG shows the strip on there. |
Member
|
just a fly-by comment: in the SVG we rely on certain IDs and classes for the components, see the (slightly hidden data/layouts/README.md). Our test suite checks for required things to be present (if you have a Button A we expect a Button A, Button A Leader, etc.) but we don't check for those to be not present if not needed. IOW an SVG may have an element with id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We emulate the touch bar as two additional buttons for this tablet.
See https://gitlab.freedesktop.org/libevdev/udev-hid-bpf/-/merge_requests/222