bump selkies, ingest file_transfers validator fix#157
bump selkies, ingest file_transfers validator fix#157Ca-moes wants to merge 1 commit intolinuxserver:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
|
Bad timing, Selkies is currently not compatible with LSIO images at head. They are working on getting their Desktop image out with WebRTC support. Once that has been bug bashed the changes from this will be merged with https://github.com/selkies-project/selkies/tree/lsio and the base images will need an overhaul to support WebRTC along with lots of documentation. |
3 participants
Description:
Bumps the pinned Selkies SHA from
a49d310ato38f0bed8in bothDockerfileandDockerfile.aarch64(4 occurrences total of the same SHA, +4/−4 net).38f0bed8is currentselkies-project/selkiesmainHEAD and is the merge commit of selkies-project/selkies#243. No other commits between the previous pin and this one onmain, so the diff is the validator fix only.Benefits of this PR and context:
#243 fixes a list-type validator bug in
src/selkies/settings.pywhereSELKIES_FILE_TRANSFERS=none(and"") — both documented in the help text as the way to disable transfers — were rejected by themeta.allowedfilter and silently fell back to the system defaultupload,download. The user's intent to disable file transfers from the environment was lost.After the fix the validator resolves
'none'/''to[]correctly.enumsemantics and the existing typo warn-and-fallback path (e.g.SELKIES_FILE_TRANSFERS=uploadx) are unchanged.The most recent baseimage bump (
2df5f01, 2026-05-03) pinned a SHA dated several hours after #243 merged but on a divergent line of history that does not include it, so users on the latest baseimage still hit the original behaviour. This PR aligns the pin withmainHEAD.How Has This Been Tested?
Validated upstream (selkies-project/selkies) before the merge with a Python harness importing
selkies.settingsafter settingSELKIES_FILE_TRANSFERSto each of:none,"",upload,upload,download,uploadx, and unset. Results matrix in the upstream PR description: pre-fixnone/""→['upload','download'](silent fallback withWARNING); post-fix →[](no warning). Typo path (uploadx) and enum semantics unchanged.I did not rebuild the LinuxServer baseimage locally for this PR — the change is a pinned-SHA bump only, with no Dockerfile structure or build-step changes, so the existing CI build should validate the integration.
Source / References: