Fix UniFi app credential test validation#890
Merged
mvdkleijn merged 1 commit intolinuxserver:masterfrom Feb 2, 2026
Merged
Conversation
The test() method was using appTest() which only checked HTTP status codes, causing false "Invalid credentials" errors even when credentials were valid. This fix aligns the test() method with the working livestats() approach. Changes: - Use execute() directly with explicit POST method (same as livestats) - Handle HTTP 400 errors for self-hosted controller auth failures - Handle HTTP 401/403 errors for UDM auth failures - Validate self-hosted response body (meta.rc === "ok") - Verify login by fetching stats to confirm session is valid - Provide descriptive error messages for different failure scenarios Fixes linuxserver#640, linuxserver#695, linuxserver#811
Collaborator
|
Sorry for the delay. I was busy working on https://opencommit.eu related stuff. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the UniFi app
test()method which was incorrectly reporting "Invalid credentials" even when credentials were valid and the dashboard stats were working correctly.Root Cause
The original
test()method usedappTest()which only checked HTTP status codes. This approach had several issues:livestats()which implicitly validates by successfully fetching data)Changes
execute()directly with explicit POST method (matchinglivestats()behavior)meta.rc === "ok")Related Issues
Testing
Tested on:
Test Results
Test Configuration
https://endpoint (HTTP redirects to HTTPS on UDM)Notes
livestats()were needed as it was already working correctly