Skip to content

Conversation

@dorianim
Copy link
Member

@dorianim dorianim commented Nov 15, 2025

Description

This allows users to define a custom letter template in /etc/linuxmuster-linuxclient7/config.yml. e.g.:

shares:
  letterTemplate: "_{letter}"

The default nameTemplate is ({letter}:).

Fixes #33

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests
  • Debian 13 client

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.93%. Comparing base (4939eb7) to head (7b17b43).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...on3/dist-packages/linuxmusterLinuxclient7/setup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   61.47%   61.93%   +0.45%     
==========================================
  Files          18       18              
  Lines        1529     1542      +13     
==========================================
+ Hits          940      955      +15     
+ Misses        589      587       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dorianim dorianim force-pushed the feat/customShareNameTemplate branch from d4e2d8c to 3dd37a0 Compare November 15, 2025 14:47
@dorianim dorianim force-pushed the feat/customShareNameTemplate branch from bb3357b to 656b8ab Compare November 15, 2025 15:10
@dorianim dorianim force-pushed the feat/customShareNameTemplate branch from 656b8ab to d740ae2 Compare November 15, 2025 15:18
@dorianim dorianim force-pushed the feat/customShareNameTemplate branch from 98fa030 to 7b17b43 Compare November 15, 2025 15:29
@dorianim dorianim merged commit 8d706ad into master Nov 15, 2025
5 checks passed
@dorianim dorianim deleted the feat/customShareNameTemplate branch November 15, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to disable drive letter on home drive

2 participants