nemo-places-sidebar.c: Restore visibility of mounts with no associated volume #3670
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
associated volume. We started skipping these in 9381561, but there are some legitimate instances where these should be shown, and are still shown in other areas of Nemo (the desktop, the move/copy-to submenus). One case is Virtualbox shared folders. If sharing a host folder with a guest and no mount point is provided, guest-additions mounts this in /media and it shows up in the GVolumeMonitor (and desktop, etc...). If a mount-point *is* provided, and that folder exists on the guest, the mount is *not* visible in a GVolumeMonitor, and will not be visible in Nemo, except as a normal folder. This seems logical. Another seems to be cifs/samba mounts, depending on how they're mounted. Using smb:// uris causes these to appear in the Network section, but using mount they no longer appear in the sidebar in any section. The other part of that commit, skipping shadowed mounts, remains correct - and these other places mentioned above were already filtering these out as well. Ref: linuxmint/mint22.3-beta#67.
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Dec 31, 2025
This reverts part of af72ce0. While it likely doesn't affect anything in core Cinnamon (changing what isRemovable() checks would probably keep these mounts hidden anyhow), other applets might choose to display these. See linuxmint/nemo#3670.
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Dec 31, 2025
This reverts part of af72ce0. While it likely doesn't affect anything in core Cinnamon (changing what isRemovable() checks would probably keep these mounts hidden anyhow), other applets might choose to display these. See linuxmint/nemo#3670. Ref: linuxmint/mint22.3-beta#67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started skipping these in 9381561, but there are some legitimate instances where these should be shown, and are still shown in other areas of Nemo (the desktop, the move/copy-to submenus).
One case is Virtualbox shared folders. If sharing a host folder with a guest and no mount point is provided, guest-additions mounts this in /media and it shows up in the GVolumeMonitor (and desktop, etc...). If a mount-point is provided, and that folder exists on the guest, the mount is not visible in a GVolumeMonitor, and will not be visible in Nemo, except as a normal folder. This seems logical.
Another seems to be cifs/samba mounts, depending on how they're mounted. Using smb:// uris causes these to appear in the Network section, but using mount they no longer appear in the sidebar in any section.
The other part of that commit, skipping shadowed mounts, remains correct - and these other places mentioned above were already filtering these out as well.
Ref:
linuxmint/mint22.3-beta#67.