screensheild.js: Listen to changes to allow floating setting#13624
Merged
mtwebster merged 1 commit intolinuxmint:masterfrom Mar 8, 2026
Merged
screensheild.js: Listen to changes to allow floating setting#13624mtwebster merged 1 commit intolinuxmint:masterfrom
mtwebster merged 1 commit intolinuxmint:masterfrom
Conversation
Member
|
Why don't we just check it in |
Contributor
Author
|
Sure, I can do that. Is there a reason one way is better than the other? |
We were only reading this setting at creation time. Instead read it on each activation in case the value changed. The timer to start widgets floating also wasn't getting started on first show.
JosephMcc
force-pushed
the
screensaver-settings-1
branch
from
ed742bb to
65aa531
Compare
Contributor
Author
|
Done. Updated and force pushed. |
Member
|
Just so you don't need a signal handler - the setting will never change while the screensaver's active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were only reading this setting at creation time and not updating on settings changes. The timer to start widgets floating also wasn't getting started on first show.