fix: allow empty affiliations array in PATCH project affiliations

[skwowet]

Summary

• Allow empty affiliations array in PATCH /members/:memberId/project-affiliations/:projectId to support removing all project affiliations
• Make verifiedBy optional when clearing affiliations (still required when adding)

---

Note

Low Risk
Low risk validation and persistence tweak confined to a single PATCH endpoint; main risk is client behavior changes when sending empty arrays and ensuring recalculation still behaves as expected.

Overview
Updates PATCH /members/:memberId/project-affiliations/:projectId to support clearing all affiliations by allowing an empty affiliations array.

Makes verifiedBy optional only when affiliations is empty (enforced via a schema refine), and skips insertMemberSegmentAffiliations when no affiliations are provided while still deleting existing rows and triggering recalculation.

^{Written by Cursor Bugbot for commit 34acf97. This will update automatically on new commits. Configure here.}

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.

[Copilot]

Pull request overview

This PR updates the public members API PATCH handler for project affiliations to support clearing all affiliations by accepting an empty affiliations array, while only requiring verifiedBy when actually adding affiliations.

Changes:

• Allow affiliations: [] in the request body (removes the previous .min(1) constraint).
• Make verifiedBy optional in the schema, and enforce it conditionally when affiliations is non-empty.
• Skip inserting rows when clearing affiliations, while still deleting existing affiliations and triggering recalculation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.