fix: Update __sw_64__ platform settings for QWebEnginePage#238
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Jan 20, 2026
Merged
fix: Update __sw_64__ platform settings for QWebEnginePage#238deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
- Changed the environment variable for QWebEnginePage to use --js-flags=--jitless instead of disabling the sandbox. - This adjustment aims to improve stability on the __sw_64__ platform. Log: as title bug: https://pms.uniontech.com/bug-view-347387.html
deepin pr auto review这段代码主要针对 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
5. 改进建议代码 // 解决__sw_64__平台使用QWebEnginePage崩溃的问题
// 原因:申威架构可能不支持V8引擎JIT所需的特定指令,导致非法指令崩溃。
// 副作用:禁用JIT会导致JS执行性能显著下降,但保留了沙箱安全性。
#ifdef __sw_64__
qDebug() << "Running on __sw_64__ platform, applying workaround: disabling JIT (--js-flags=--jitless)";
// 注意:这里替换了之前的 --no-sandbox,以在解决崩溃的同时保持沙箱安全防护
qputenv("QTWEBENGINE_CHROMIUM_FLAGS", "--js-flags=--jitless");
#endif总结如果该改动确实解决了申威平台上的崩溃问题,那么这是一个非常积极的改动,因为它在解决兼容性问题的同时,避免了引入严重的安全隐患(即 |
lzwind
approved these changes
Jan 20, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: as title
bug: https://pms.uniontech.com/bug-view-347387.html