Skip to content

Comments

fix: 修复联想YOGA pro14(Ultra7)使用电源键无法关闭显示器的问题#1028

Closed
applyforprof wants to merge 0 commit intolinuxdeepin:masterfrom
applyforprof:master
Closed

fix: 修复联想YOGA pro14(Ultra7)使用电源键无法关闭显示器的问题#1028
applyforprof wants to merge 0 commit intolinuxdeepin:masterfrom
applyforprof:master

Conversation

@applyforprof
Copy link

@applyforprof applyforprof commented Feb 5, 2026

BUG: 349047
Influence: Power

Summary by Sourcery

Bug Fixes:

  • Fix power key behavior on certain devices by enabling the screen saver and briefly delaying before forcing the display power state off on X11.

@deepin-ci-robot
Copy link

Hi @applyforprof. Thanks for your PR. 😃

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@deepin-ci-robot
Copy link

Hi @applyforprof. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the X11 code path for turning off the screen so that it first enables the X screen saver and waits briefly before forcing DPMS off, improving compatibility on Lenovo YOGA Pro 14 (Ultra7) when using the power button to turn off the display.

Sequence diagram for updated X11 screen power-off behavior

sequenceDiagram
    actor User
    participant PowerButton
    participant Manager
    participant XServer
    participant xset
    participant dpms

    User ->> PowerButton: Press power button
    PowerButton ->> Manager: systemTurnOffScreen()

    alt Wayland_session
        Manager ->> XServer: dde_wldpms -s Off
        XServer -->> Manager: Screen off (Wayland)
    else X11_session
        Manager ->> xset: xset s on
        xset -->> Manager: Result or error
        Manager ->> Manager: Sleep 100ms
        Manager ->> dpms: ForceLevelChecked(DPMSModeOff)
        dpms -->> Manager: Screen off (DPMS)
    end

    Manager -->> PowerButton: Return
    PowerButton -->> User: Display turned off
Loading

File-Level Changes

Change Details Files
Improve X11-based screen-off sequence by enabling screen saver and adding a short delay before forcing DPMS off to increase reliability.
  • Before invoking DPMSModeOff, run xset s on to ensure the X screen saver is enabled.
  • Log a warning instead of failing hard if enabling the screen saver via xset returns an error.
  • Insert a 100ms sleep between the xset call and the DPMS off command to give X time to process the screen saver state change.
keybinding1/utils.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The hard-coded 100ms time.Sleep before calling dpms.ForceLevelChecked is a bit of a magic value; consider either documenting why this delay is needed or extracting it into a named constant so future maintainers understand and can tune it more easily.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The hard-coded 100ms `time.Sleep` before calling `dpms.ForceLevelChecked` is a bit of a magic value; consider either documenting why this delay is needed or extracting it into a named constant so future maintainers understand and can tune it more easily.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: applyforprof

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants