kexec-unseal-key: calls new etc/functions' show_totp_until_esc() before prompting for TPM DUK passphrase#2024
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom Feb 3, 2026
Conversation
Collaborator
Author
|
@Tonux599 hmmm just saw your comment at #1993 (comment) |
Collaborator
Author
|
@Tonux599 I think all those implementations are complementary and not competing? Reasoning:
I think I prefer this PR if I had to choose one implementation (at the end of the day, TPM DUK validates more measurements than HOTP, and TPM DUK goal is to have a safe space to type decryption key passphrase that is not the LUKS Disk Recovery Key passphrase (so cannot be used if captured to decrypt disk when disk extracted from platform). Please dump some thoughts @Tonux599 :) |
Collaborator
Author
|
Lacks sanitation, should be merged/conflicts resolved on top of merged #1935 which does it right |
…re prompting for TPM DUK passphrase Added function show_totp_until_esc() in etc/functions: - Shows "[TIMESTAMP] | TOTP code: XXXXXX | Press Esc to continue..." (pipe-separated). - Caches TOTP for 1 second and only redraws when the second changes (avoids flicker). - Polls input every 200 ms and returns immediately on ESC, printing a blank line for separation. - Shows "TOTP unavailable" when a code cannot be fetched (initial or failure). Signed-off-by: Thierry Laurion <insurgo@riseup.net>
41d998d to
780a9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #1993 : Add
Timestamp UTC | TOTP code: XXXXXX | Press Esc to continue...before TPM DUK passphrase prompt (see screenshot below).Added function show_totp_until_esc() in etc/functions:
Qemu:
./docker_repro.sh make BOARD=qemu-coreboot-fbwhiptail-tpm2-hotp-prod_quiet USB_TOKEN=Nitrokey3NFC PUBKEY_ASC=pubkey.asc inject_gpg run@Tonux599