Skip to content

modules/* : remove unused configure options and review modules that were still compiled with -O2 as opposed to -Os#1477

Draft
tlaurion wants to merge 1 commit intolinuxboot:masterfrom
tlaurion:review_modules_configure_compile_options
Draft

modules/* : remove unused configure options and review modules that were still compiled with -O2 as opposed to -Os#1477
tlaurion wants to merge 1 commit intolinuxboot:masterfrom
tlaurion:review_modules_configure_compile_options

Conversation

@tlaurion
Copy link
Collaborator

Note: is libusb still needed by anything? gpg2 doesn't require it anymore? Review

…ere still compiled with -O2 as opposed to -Os

Note: is libusb still needed by anything? gpg2 doesn't require it anymore? Review
@tlaurion
Copy link
Collaborator Author

tlaurion commented Aug 23, 2023

user@heads-tests-deb12:/tmp$ wget https://output.circle-artifacts.com/output/job/d4015c6a-b47d-44d4-8bb7-a092af4e88b3/artifacts/0/build/x86/x230-hotp-maximized/sizes.txt -O PR -q
user@heads-tests-deb12:/tmp$ wget https://output.circle-artifacts.com/output/job/ca627a62-547e-42cd-8efb-a2b750622cac/artifacts/0/build/x86/x230-hotp-maximized/sizes.txt -O master -q
user@heads-tests-deb12:/tmp$ diff -u master PR
--- master	2023-08-22 12:33:03.000000000 -0400
+++ PR	2023-08-23 16:27:53.000000000 -0400
@@ -1,4 +1,4 @@
-2023-08-22 12:23:55-04:00 d8a9a1e77e1731302e5b464b789c872a78e738c4 clean
+2023-08-23 16:14:03-04:00 1d80dead78dbc016675a9c3f9009df01fe5f37e5 clean
  2486400:/root/project/build/x86/x230-hotp-maximized/bzImage
   685056:/root/project/build/x86/x230-hotp-maximized/modules.cpio
 -----
@@ -146,5 +146,5 @@
      924:./sbin/config-dhcp.sh
     1064:./sbin/insmod
 -----
- 4219392:build/x86/x230-hotp-maximized/initrd.cpio.xz
-12582912:/root/project/build/x86/x230-hotp-maximized/heads-x230-hotp-maximized-v0.2.0-1753-gd8a9a1e.rom
+ 4218880:build/x86/x230-hotp-maximized/initrd.cpio.xz
+12582912:/root/project/build/x86/x230-hotp-maximized/heads-x230-hotp-maximized-v0.2.0-1754-g1d80dea.rom

Analysis: compression is better while all binaries/libs else stays the same ? This is weird.
Minor gains but still: 4219392-4218880=512bytes.

@tlaurion tlaurion marked this pull request as draft August 23, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant