ltx_send_message() retry write properly on EAGAIN #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are doing file transfer we can easily saturate the serial connection or pipe we write into and get EAGAIN. The original code just ignored all write errors, which caused lost bytes and broken communication with kirk. This commit fixes two bugs in the retry loop: - properly adjust the buffer position on subsequent write attempts - do a short sleep on EAGAIN and retry later on We also print message into stderr when write() failed for any other reason than EAGAIN so that there is at least some hint of a failure in that case. Signed-off-by: Cyril Hrubis <metan@ucw.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are doing file transfer we can easily saturate the serial connection or pipe we write into and get EAGAIN.
The original code just ignored all write errors, which caused lost bytes and broken communication with kirk.
This commit fixes two bugs in the retry loop:
We also print message into stderr when write() failed for any other reason than EAGAIN so that there is at least some hint of a failure in that case.