ci: Pass in __bootc_validation as boolean, not string#171
Closed
Conversation
Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR ensures the Sequence diagram for passing __bootc_validation as boolean in CIsequenceDiagram
participant CI as "CI Workflow"
participant tox as "tox-lsr"
participant Ansible as "Ansible"
CI->>tox: Run tox-lsr with extra-vars
tox->>Ansible: Pass __bootc_validation: true (YAML boolean)
Ansible->>Ansible: Treat __bootc_validation as boolean
Sequence diagram for improved TF test failure detectionsequenceDiagram
participant CI as "CI Workflow (tft_citest_bad.yml)"
participant GitHub as "GitHub API"
CI->>GitHub: Query workflow runs for PR title
GitHub-->>CI: Return runs with conclusion
CI->>CI: Check for failure or cancelled conclusion
CI->>CI: Handle failed/cancelled workflow
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in a YAML true value as
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Add detailed guidance for running CI tests locally with tox-lsr and QEMU, bump tox-lsr version across workflows, ensure __bootc_validation is passed as a YAML boolean, and update rerun logic to include cancelled runs.
CI:
Documentation: