generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 8
ci: Use ansible 2.19 for fedora 42 testing; support python 3.13 #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This also requires upgrading to tox-lsr 3.11.0 Ansible 2.19 will be released soon and has some changes which will require fixes in system roles. This adds 2.19 to our testing matrix on fedora 42 so that we can start addressing these issues. python 3.13 is now being used on some platforms. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideUpdates CI workflows to test with Ansible 2.19 on Fedora-42, add Python 3.13 to the testing matrix, and bump tox-lsr to 3.11.0 across workflows. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @richm - I've reviewed your changes - here's some feedback:
- Consider defining the tox-lsr version as a single variable or using a reusable workflow to avoid repeating the upgrade across all CI YAML files.
- Add an explicit installation or validation step for Python 3.13 in workflows where it may not be preinstalled on the runner.
- Ensure the ansible-core 2.19 bump is applied consistently across all relevant job matrices to keep the test matrix aligned.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
NOTE: This also requires upgrading to tox-lsr 3.11.0 Ansible 2.19 will be released soon and has some changes which will require fixes in system roles. This adds 2.19 to our testing matrix on fedora 42 so that we can start addressing these issues. python 3.13 is now being used on some platforms. Using ansible-core 2.18 requires using py311 for pylint and other python checkers. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This also requires upgrading to tox-lsr 3.11.0
Ansible 2.19 will be released soon and has some changes which will
require fixes in system roles. This adds 2.19 to our testing matrix
on fedora 42 so that we can start addressing these issues.
python 3.13 is now being used on some platforms.
Using ansible-core 2.18 requires using py311 for pylint and other
python checkers.