Skip to content

Conversation

@martinpitt
Copy link
Contributor

@martinpitt martinpitt commented Jun 14, 2025

Cause: The test used a temporary variable ansible_managed, but that is a "magic" string constant. Ansible 2.19 does not permit assigning to it any more.

Consequence: Tests failed with Ansible 2.19.

Fix: Rename the variable.


This should fix the F42/ansible 2.19 failure introduced in #188

Summary by Sourcery

Bug Fixes:

  • Fix test failure on Ansible 2.19 by renaming the temporary ansible_managed variable to __ansible_managed.

Cause: The test used a temporary variable `ansible_managed`, but that is
a "magic" string constant. Ansible 2.19 does not permit assigning to it
any more.

Consequence: Tests failed with Ansible 2.19.

Fix: Rename the variable.
@martinpitt martinpitt requested review from Jakuje and richm as code owners June 14, 2025 15:07
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 14, 2025

Reviewer's Guide

Renames the test variable ansible_managed to __ansible_managed in the header check to avoid assigning to the Ansible reserved variable and restore compatibility with Ansible 2.19.

File-Level Changes

Change Details Files
Rename magic ansible_managed variable to prevent reserved-name assignment
  • Updated the assertion condition to check for __ansible_managed instead of ansible_managed
  • Renamed the variable in the vars section from ansible_managed to __ansible_managed
tests/tasks/check_header.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martinpitt - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martinpitt
Copy link
Contributor Author

[citest]

@martinpitt
Copy link
Contributor Author

Remaining failure reproduces locally:

tox -e qemu-ansible-core-2.19 -- --image-name fedora-42 --log-level=debug tests/tests_user_config.yml

The generated config fails to validate, and it's not obvious what's going wrong. Back to draft.

@martinpitt martinpitt marked this pull request as ready for review June 15, 2025 07:53
@martinpitt
Copy link
Contributor Author

OK, let's land this in steps.

@martinpitt martinpitt merged commit 2d50d82 into linux-system-roles:main Jun 15, 2025
34 of 36 checks passed
@martinpitt martinpitt deleted the a219 branch June 15, 2025 07:53
@martinpitt
Copy link
Contributor Author

The test failure is the same None disaster as in linux-system-roles/sudo#62. The written value is

#
# Ansible managed
#
# system_role:ssh

NoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNoneNone

@martinpitt
Copy link
Contributor Author

Sent a possible solution to #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants