-
Notifications
You must be signed in to change notification settings - Fork 21
fix: Avoid setting ansible_managed variable #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cause: The test used a temporary variable `ansible_managed`, but that is a "magic" string constant. Ansible 2.19 does not permit assigning to it any more. Consequence: Tests failed with Ansible 2.19. Fix: Rename the variable.
Reviewer's GuideRenames the test variable File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martinpitt - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[citest] |
|
Remaining failure reproduces locally: The generated config fails to validate, and it's not obvious what's going wrong. Back to draft. |
|
OK, let's land this in steps. |
|
The test failure is the same |
|
Sent a possible solution to #190 |
Cause: The test used a temporary variable
ansible_managed, but that is a "magic" string constant. Ansible 2.19 does not permit assigning to it any more.Consequence: Tests failed with Ansible 2.19.
Fix: Rename the variable.
This should fix the F42/ansible 2.19 failure introduced in #188
Summary by Sourcery
Bug Fixes: