test: ensure NetworkManager, ensure eth1 is active

[richm]

This is mainly needed on el7 - NetworkManager is installed by default, or
somewhere else, on el8 and later.

Additionally, if the NetworkManager-server-config package is installed, then
the secondary interface will not be active, so ensure it is active.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Ensure NetworkManager is installed, running, and at a sufficient version for the MAC address match tests and update test configurations accordingly

Tests:

• Install NetworkManager, gather its version, and start its service in the MAC address match test playbook
• Add a condition to require NetworkManager version >= 1.18.0 before running the MAC address match test
• Update the minimum supported NetworkManager version to 1.18.0 in the provider tests configuration

[sourcery-ai]

Reviewer's Guide

This PR explicitly installs and starts NetworkManager for the MAC address match test on EL7, captures its version to enforce a minimum version requirement (>=1.18.0), and updates the provider tests accordingly.

File-Level Changes

Change	Details	Files
Add installation and version detection of NetworkManager in test setup	Introduce a block to install NetworkManager when not on EL6 Collect package facts to retrieve installed versions Set a fact 'networkmanager_version' from the fetched package info	tests/tests_mac_address_match_nm.yml
Guard playbook import with a minimum NetworkManager version check	Add a condition 'networkmanager_version is version("1.18.0", ">=")' to the import task	tests/tests_mac_address_match_nm.yml
Ensure NetworkManager service is running before tests	Add a service task to start NetworkManager at the beginning of the playbook	tests/playbooks/tests_mac_address_match.yml
Update minimum NetworkManager version requirement in provider tests	Set MINIMUM_VERSION to '1.18.0' for the MAC address match playbook in ensure_provider_tests.py	tests/ensure_provider_tests.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.25%. Comparing base (1b57520) to head (882ecfa).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   43.11%   43.25%   +0.13%     
==========================================
  Files          12       12              
  Lines        3124     3121       -3     
==========================================
+ Hits         1347     1350       +3     
+ Misses       1777     1771       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[richm]

[citest]

[richm]

[citest]

[richm]

[citest]

[richm]

[citest]