Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 11, 2026

Add Fedora 43, remove Fedora 41 from Testing Farm CI

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Replace Fedora 41 with Fedora 43 in the Testing Farm CI workflow matrix and supported platforms list.

Add Fedora 43, remove Fedora 41 from Testing Farm CI

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner February 11, 2026 19:09
@richm richm self-assigned this Feb 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Testing Farm CI to stop testing on Fedora 41 and start testing on Fedora 43, adjusting both platform detection and the GitHub Actions test matrix accordingly.

Flow diagram for updated Fedora platform selection in Testing Farm CI

flowchart TD
  A[Read meta/main.yml] --> B[Check galaxy_info.galaxy_tags for tag matching fedora]
  B -->|yes| C[Initialize supported_platforms]
  C --> D[Add Fedora-42 to supported_platforms]
  D --> E[Add Fedora-43 to supported_platforms]
  B -->|no| F[Do not add Fedora generic platforms]

  E --> G[Build GitHub Actions matrix include list]
  G --> H[Include platform Fedora-42 with ansible_version 2.19]
  H --> I[Include platform Fedora-43 with ansible_version 2.20]
  I --> J[Run Testing Farm jobs for Fedora-42 and Fedora-43]
Loading

File-Level Changes

Change Details Files
Update supported Fedora platforms discovery in Testing Farm workflow to include Fedora 43 and drop Fedora 41.
  • Remove automatic inclusion of Fedora-41 in the supported_platforms list when Fedora is detected in galaxy tags.
  • Add automatic inclusion of Fedora-43 in the supported_platforms list when Fedora is detected in galaxy tags.
.github/workflows/tft.yml
Adjust Testing Farm GitHub Actions matrix to test on Fedora 43 with a newer Ansible version and stop testing Fedora 41.
  • Remove Fedora-41 entry from the matrix include list.
  • Keep Fedora-42 in the matrix with Ansible 2.19.
  • Add Fedora-43 to the matrix with Ansible 2.20.
.github/workflows/tft.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/tft.yml:104` </location>
<code_context>
           - platform: Fedora-42
             ansible_version: 2.19
+          - platform: Fedora-43
+            ansible_version: 2.20
           - platform: CentOS-7-latest
             ansible_version: 2.9
</code_context>

<issue_to_address>
**issue (bug_risk):** Quote the Ansible version to avoid YAML numeric parsing issues (e.g., 2.20 -> 2.2).

This avoids the value being normalized before it reaches downstream tooling. Please also quote the other `ansible_version` entries for consistency and to prevent similar parsing issues elsewhere.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- platform: Fedora-42
ansible_version: 2.19
- platform: Fedora-43
ansible_version: 2.20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Quote the Ansible version to avoid YAML numeric parsing issues (e.g., 2.20 -> 2.2).

This avoids the value being normalized before it reaches downstream tooling. Please also quote the other ansible_version entries for consistency and to prevent similar parsing issues elsewhere.

@richm richm merged commit 0a854d4 into main Feb 11, 2026
36 of 38 checks passed
@richm richm deleted the f43 branch February 11, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant