-
Notifications
You must be signed in to change notification settings - Fork 13
ci: Add Fedora 43, remove Fedora 41 from Testing Farm CI #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Fedora 43, remove Fedora 41 from Testing Farm CI Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Testing Farm CI to stop testing on Fedora 41 and start testing on Fedora 43, adjusting both platform detection and the GitHub Actions test matrix accordingly. Flow diagram for updated Fedora platform selection in Testing Farm CIflowchart TD
A[Read meta/main.yml] --> B[Check galaxy_info.galaxy_tags for tag matching fedora]
B -->|yes| C[Initialize supported_platforms]
C --> D[Add Fedora-42 to supported_platforms]
D --> E[Add Fedora-43 to supported_platforms]
B -->|no| F[Do not add Fedora generic platforms]
E --> G[Build GitHub Actions matrix include list]
G --> H[Include platform Fedora-42 with ansible_version 2.19]
H --> I[Include platform Fedora-43 with ansible_version 2.20]
I --> J[Run Testing Farm jobs for Fedora-42 and Fedora-43]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/tft.yml:104` </location>
<code_context>
- platform: Fedora-42
ansible_version: 2.19
+ - platform: Fedora-43
+ ansible_version: 2.20
- platform: CentOS-7-latest
ansible_version: 2.9
</code_context>
<issue_to_address>
**issue (bug_risk):** Quote the Ansible version to avoid YAML numeric parsing issues (e.g., 2.20 -> 2.2).
This avoids the value being normalized before it reaches downstream tooling. Please also quote the other `ansible_version` entries for consistency and to prevent similar parsing issues elsewhere.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - platform: Fedora-42 | ||
| ansible_version: 2.19 | ||
| - platform: Fedora-43 | ||
| ansible_version: 2.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Quote the Ansible version to avoid YAML numeric parsing issues (e.g., 2.20 -> 2.2).
This avoids the value being normalized before it reaches downstream tooling. Please also quote the other ansible_version entries for consistency and to prevent similar parsing issues elsewhere.
Add Fedora 43, remove Fedora 41 from Testing Farm CI
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: