Skip to content

ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richm wants to merge 1 commit into from
Closed

ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/qemu-kvm-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:

env:
TOX_ARGS: "--skip-tags tests::infiniband,tests::nvme,tests::scsi"
ANSIBLE_INJECT_FACT_VARS: "false"

steps:
- name: Checkout repo
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ jobs:
SR_ARTIFACTS_DIR=${{ steps.set_vars.outputs.ARTIFACTS_DIR }};\
SR_TEST_LOCAL_CHANGES=false;\
SR_LSR_USER=${{ vars.SR_LSR_USER }};\
SR_ANSIBLE_INJECT_FACT_VARS=false;\
SR_ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }}"
# Note that LINUXSYSTEMROLES_SSH_KEY must be single-line, TF doesn't read multi-line variables fine.
secrets: "SR_LSR_DOMAIN=${{ secrets.SR_LSR_DOMAIN }};\
Expand Down
4 changes: 2 additions & 2 deletions tests/vars/rh_distros_vars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ __bootloader_rh_distros:
__bootloader_rh_distros_fedora: "{{ __bootloader_rh_distros + ['Fedora'] }}"

# Use this in conditionals to check if distro is Red Hat or clone
__bootloader_is_rh_distro: "{{ ansible_facts['distribution'] in __bootloader_rh_distros }}"
__bootloader_is_rh_distro: "{{ ansible_distribution in __bootloader_rh_distros }}"

# Use this in conditionals to check if distro is Red Hat or clone, or Fedora
__bootloader_is_rh_distro_fedora: "{{ ansible_facts['distribution'] in __bootloader_rh_distros_fedora }}"
__bootloader_is_rh_distro_fedora: "{{ ansible_distribution in __bootloader_rh_distros_fedora }}"
Loading