ci: use by default INJECT_FACTS_AS_VARS=false

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

• Pass ANSIBLE_INJECT_FACT_VARS=false via workflow environment and Terraform inputs so tests run with facts not injected as variables.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures Ansible to run with INJECT_FACTS_AS_VARS disabled in CI workflows by propagating the corresponding environment/TF variable, preparing for Ansible 2.20+ behavior where facts are only available under ansible_facts.

Flow diagram for environment propagation of SR_ANSIBLE_INJECT_FACT_VARS

flowchart TD
  start([CI_run_started])
  readWorkflow["Read tft.yml workflow"]
  runSetVars["Run set_vars step<br/>populate ARTIFACTS_DIR, ARTIFACTS_URL"]
  buildEnv["Build env_vars string for Terraform<br/>include SR_ANSIBLE_INJECT_FACT_VARS=false"]
  runTF["Run Terraform with env_vars"]
  tfToAnsible["Terraform invokes Ansible<br/>with INJECT_FACTS_AS_VARS=false"]
  ansibleFacts["Ansible exposes facts only under ansible_facts"]
  ciEnd([CI_run_completed])

  start --> readWorkflow --> runSetVars --> buildEnv --> runTF --> tfToAnsible --> ansibleFacts --> ciEnd

Loading

File-Level Changes

Change	Details	Files
Propagate Ansible INJECT_FACTS_AS_VARS setting into the Terraform-based test workflow so roles can switch from bare fact vars to ansible_facts lookups.	Extend the Terraform workflow job variables string to include SR_ANSIBLE_INJECT_FACT_VARS=false so downstream tooling can detect that Ansible facts are not injected as top-level vars.	playbooks/templates/.github/workflows/tft.yml
Set ANSIBLE_INJECT_FACT_VARS in the QEMU/KVM integration tests workflow to align CI behavior with upcoming Ansible defaults.	Add ANSIBLE_INJECT_FACT_VARS="false" to the job-level env section so all steps run with fact injection disabled.	playbooks/templates/.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new env var names differ (SR_ANSIBLE_INJECT_FACT_VARS vs ANSIBLE_INJECT_FACT_VARS); double-check this is intentional and aligned with how the variable is consumed in downstream scripts or jobs.
• Consider being consistent with the value type for ANSIBLE_INJECT_FACT_VARS (unquoted false vs quoted "false") so that any consumers that treat it as a boolean or string behave predictably.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new env var names differ (`SR_ANSIBLE_INJECT_FACT_VARS` vs `ANSIBLE_INJECT_FACT_VARS`); double-check this is intentional and aligned with how the variable is consumed in downstream scripts or jobs.
- Consider being consistent with the value type for `ANSIBLE_INJECT_FACT_VARS` (unquoted `false` vs quoted `"false"`) so that any consumers that treat it as a boolean or string behave predictably.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}