bnxt_re/lib: Support direct verbs #1654
Open
+919
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbasavapatna
force-pushed
the
dv-upstream
branch
from
8042660 to
2617428
Compare
sbasavapatna
force-pushed
the
dv-upstream
branch
from
2617428 to
7c19ba0
Compare
sbasavapatna
force-pushed
the
dv-upstream
branch
from
7c19ba0 to
130c041
Compare
Member
|
Please take the debug_file stuff out of here, I'm not keen on every driver implementing their own stuff. We already have tracing frameworks supported, why not use one? |
jgunthorpe
reviewed
Dec 17, 2025
| struct bnxt_re_dv_db_region_attr *attr); | ||
| int bnxt_re_dv_get_default_db_region(struct ibv_context *ibvctx, | ||
| struct bnxt_re_dv_db_region_attr *out); | ||
| void *bnxt_re_dv_umem_reg(struct ibv_context *ibvctx, |
Member
There was a problem hiding this comment.
void *? That shouldn't be. Why do you have these functions when there is no kernel side?
To commit: ?? ("RDMA/bnxt_re: Direct Verbs: Support CQ and QP verbs").
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
The following Direct Verb (DV) APIs have been implemented in this patch. Doorbell Region Direct Verbs: ----------------------------- - bnxt_re_dv_alloc_db_region(): This will allow the appliation to create extra doorbell regions and use the associated doorbell page index in dv_create_qp() and use the associated DB address while ringing the doorbell. - bnxt_re_dv_free_db_region(): Free the allocated doorbell region. - bnxt_re_dv_get_default_db_region(): Return the default doorbell page index and doorbell page address associated with the ucontext. Umem Registration Direct Verbs: ------------------------------- - bnxt_re_dv_umem_reg(): Register the user memory to be used by the application with the library. Application can register a large chunk of memory and use it during subsequent resource creation DV APIs. Note that the API terminates in the library and the app specified memory params (addr, len) are saved and a umem-handle is returned. That is, there is no ioctl to the driver at this point to map/pin the user memory. This memory is mapped/pinned later when the application creates the required resources (CQ/QP) using respective direct verbs. This is implemented in the next patch in this series. - bnxt_re_dv_umem_dereg(): Deregister the user memory specified by the umem-handle. Co-developed-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Selvin Thyparampil Xavier <selvin.xavier@broadcom.com>
The following Direct Verb (DV) APIs have been implemented in this patch. These are implemented by enhancing the driver specific udata in existing verbs. CQ Direct Verbs: ---------------- - bnxt_re_dv_create_cq(): Create a CQ of requested size (cqe). The application must have already registered this memory using bnxt_re_dv_umem_reg(). The CQ umem-handle and umem-offset provided by the application are translated into an address for mapping and passed to the driver. - bnxt_re_dv_destroy_cq(): Destroy the DV_CQ created earlier. QP Direct Verbs: ---------------- - bnxt_re_dv_create_qp(): Create a QP using specified params (struct bnxt_re_dv_qp_init_attr). The application must have already registered SQ/RQ memory using bnxt_re_dv_umem_reg(). The SQ/RQ umem-handle and umem-offset provided by the application are translated into an address for mapping and passed to the driver. - bnxt_re_dv_destroy_qp(): Destroy the DV_QP created earlier. - bnxt_re_dv_modify_qp(): Modify QP attributes of the DV_QP. - bnxt_re_dv_query_qp(): Return QP attributes of the DV_QP. Note: ----- Some applications might want to allocate memory for all resources of a given type (CQ/QP) in one big chunk and then register that entire memory once using dv_umem_reg(). At the time of creating each individual resource, the application should pass a specific offset/length in the umem registered memory. Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Co-developed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Co-developed-by: Selvin Xavier <selvin.xavier@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
sbasavapatna
force-pushed
the
dv-upstream
branch
from
130c041 to
c841ce1
Compare
Author
|
On Thu, Dec 18, 2025 at 1:31 AM Jason Gunthorpe ***@***.***> wrote:
*jgunthorpe* left a comment (linux-rdma/rdma-core#1654)
<#1654 (comment)>
Please take the debug_file stuff out of here, I'm not keen on every driver
implementing their own stuff. We already have tracing frameworks supported,
why not use one?
Deleted the debug log patch from the series and pushed the next version.
Thanks,
-Harsha
… —
Reply to this email directly, view it on GitHub
<#1654 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTY2BJYE3NGLRRWOYN2OD34CGZCXAVCNFSM6AAAAACK7AEXQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRWHE2DSNBQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
On Thu, Dec 18, 2025 at 1:32 AM Jason Gunthorpe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In providers/bnxt_re/bnxt_re_dv.h
<#1654 (comment)>
:
> +struct bnxt_re_dv_umem_reg_attr {
+ void *addr;
+ size_t size;
+ uint32_t access_flags;
+ uint64_t pgsz_bitmap;
+ uint64_t comp_mask;
+ int dmabuf_fd;
+};
+
+struct bnxt_re_dv_db_region_attr *
+bnxt_re_dv_alloc_db_region(struct ibv_context *ctx);
+int bnxt_re_dv_free_db_region(struct ibv_context *ctx,
+ struct bnxt_re_dv_db_region_attr *attr);
+int bnxt_re_dv_get_default_db_region(struct ibv_context *ibvctx,
+ struct bnxt_re_dv_db_region_attr *out);
+void *bnxt_re_dv_umem_reg(struct ibv_context *ibvctx,
void *? That shouldn't be. Why do you have these functions when there is
no kernel side?
It is a void *, since we want to pass an opaque handle to the application.
This handle is passed back into the library during object creation. The
application provides this handle along with an offset into this memory area
to create the object (see CQ/QP creation DV APIs and commit messages).
Thanks,
-Harsha
… —
Reply to this email directly, view it on GitHub
<#1654 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGTY2BPWWJYFCN6B4PI3OWT4CGZGZAVCNFSM6AAAAACK7AEXQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBZGQZTKMBUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patchset supports Direct Verbs in the bnxt_re library.
This is required by vendor specific applications that need to manage
the HW resources directly and to implement the datapath in the
application.
To support this, the library and the driver are being enhanced to
provide Direct Verbs using which the application can allocate and
manage the HW resources (Queues, Doorbell etc) . The Direct Verbs
enable the application to implement the control path.
Patch#1 Support debug logging
Patch#2 Update kernel headers
Patch#3 Support dbr and umem direct verbs
Patch#4 Support cq and qp direct verbs
Thanks,
-Harsha