build: remove default prefix option#3399
Open
bcapener wants to merge 1 commit into
Open
Conversation
bcapener
force-pushed
the
build-remove-hard-coded-default-prefix
branch
from
87f3e80 to
7b51b86
Compare
Hard coding the default prefix causes issues on windows. meson's docs says "prefix defaults to C:/ on Windows, and /usr/local otherwise. You should always override this value.". There is no value, only downside on Windows, to setting the value here. If the user want a different value it should be overridden via the command line. Signed-off-by: Brandon Capener <bcapener@micron.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard coding the default prefix causes issues on windows. meson's docs says "prefix defaults to C:/ on Windows, and /usr/local otherwise. You should always override this value.", see https://mesonbuild.com/Builtin-options.html. There is no value, only downside on Windows, to setting the value here. If the user want a different value it should be overridden via the command line. During development we should not have to set the prefix, it should just default to a sane value.
Windows with default prefix removed
Paths
prefixdir : C:/msys64/ucrt64
sysconfdir : C:/msys64/ucrt64/etc
sbindir : C:/msys64/ucrt64/sbin
Windows with default prefix set to "prefix=/usr/local". Or, Linux with and without "prefix=/usr/local"
Paths
prefixdir : /usr/local
sysconfdir : /usr/local/etc
sbindir : /usr/local/sbin